* YAM_RE.c: removed a superflous closing brace.
1 lines of code changed in 1 file:
* YAM_RE.c: moved the attachment detection to a more appropriate location.
4 lines of code changed in 1 file:
* YAM_RE.c: treat a "inline" content-disposition just like "attachment".
1 lines of code changed in 1 file:
* mui/MainFolderListtree.c, mui/FolderEditWindow.c: newly created folders and folder groups are made the active entry in the listtree.
5 lines of code changed in 2 files:
* YAM_RE.c: added a detection of real attachments to be able to perform the rough size estimation for these parts only. All other parts without size information will be read dynamically. This refs #466.
19 lines of code changed in 2 files:
* YAM_RE.c: for attachments without an explicit size information by the header lines YAM will now do a VERY rough size estimation to be able to preallocate a buffer. Although this estimation might be far too big if there are several attachments it nevertheless speeds up parsing big mails/attachments a lot as this avoids the need to dynamically resize a constantly growing buffer for reading. The former approach required almost twice the size of an attachment as dynamic buffer, so this estimation shouldn't be too bad. This closes #466 again.
60 lines of code changed in 1 file:
* YAM_RE.c: fixed a possible memory leak when parsing mails. In case no output file handle is given the parsed text was never freed.
3 lines of code changed in 1 file:
* Config.c: implemented a check to catch the automatic detection of cyrillic charsets while the configured local charset is not cyrillic. As this might cause malformed characters the user is now asked to deactivate the automatic detection. This closes #463.
28 lines of code changed in 1 file:
* mui/MainMailListGroup.c: minor non-functional cosmetic changes.
3 lines of code changed in 1 file:
* mui/RecipientString.c: restored the behaviour of YAM 2.7 when resolving the names of address book mailing lists. Additionally the resolve process did not specify any flag for the kind of entries to search when resolving the recipients. This closes #458.
26 lines of code changed in 1 file:
* mui/MainMailListGroup.c: perform certain methods on the list object directly instead of the listview object, as these methods will be forwarded to the list object anyway.
7 lines of code changed in 1 file:
- added missing ENTER() macro. This closes #462
2 lines of code changed in 1 file:
* mui/FolderRequestListtree.c: set the notification for a changed folder tree for the correct object. The former approach used the NListview object instead of the NListtree object. This might have caused a crash, because the notification was never removed and a changed folder tree would then access a no longer existing object when the notification was eventually triggered. This closes #451.
2 lines of code changed in 1 file:
* YAM_MA.c, misc: renamed the main folder listtree object to LT_FOLDERS to make cofusions between an NListview object and its embedded NList object less likely.
67 lines of code changed in 12 files:
* UserIdentity.c: don't set a default Sent folder name as this will always reenable the custom Sent folder even if it was disabled before.
5 lines of code changed in 2 files:
* mui/WriteWindow.c: draft mails being edited a second time are no longer deleted when the user did some changes and closes the write window to discard the changes. This closes #460.
3 lines of code changed in 1 file:
* mui/AddressBookWindow.c: don't use a local variable for a new address book entry and duplicate it later on as the copy will still point to the local variable. This closes #457.
23 lines of code changed in 1 file:
* AddressBook.c: made the roor group's name optional to tell the global address book and the cache apart.
10 lines of code changed in 6 files:
* mui/AddressBookWindow.c: added a missing initialization of a new address book node. This refs #457.
4 lines of code changed in 2 files:
* mui/AddressBookWindow.c: don't require groups to have an address.
1 lines of code changed in 1 file:
* mui/MainFolderListtree.c: moved the deletion of the folder contents after the disposing of the folder image to make sure that the image file is no longer locked.
3 lines of code changed in 1 file:
* mui/WriteWindow.c: make the newly inserted entry the active one on both lists.
1 lines of code changed in 1 file:
* mui/WriteWindow.c: all attachments are now added through a single method which ensures that the tiny attachment list on the first page is made visible and that a possibly visible attachment reminder is hidden again. This method also ensures that the tiny attachment list is correctly made visible when editing a draft mail with attachments a second time.
7 lines of code changed in 1 file:
* resources/zoneinfo, tools/tzdata, extrasrc/tzcode: updated tzdata/tzcode
environment to the latest version (2013h) released by iana.org.
162 lines of code changed in 4 files:
- compilation fix
1 lines of code changed in 1 file:
* mui/MainFolderListtree.c: use the new "Folders" path when selecting an existing directory for a folder.
3 lines of code changed in 1 file:
* mui/MainFolderListtree.c: added handling of all kinds of default folders when creating a new folder after selecting "like current" as default settings.
5 lines of code changed in 1 file:
* Config.c: make sure that every config update which eventually causes the config to be saved is logged.
7 lines of code changed in 1 file:
* mui/FolderRequestPopup.c: added a NULL pointer check for unresolved folders. This refs #451.
4 lines of code changed in 1 file:
* mui/FolderRequestPopup.c: clear the folder path string if resolving the folder fails.
6 lines of code changed in 1 file:
* mime/rfc2047.c: restored a formerly replaced memcpy() call as the strlcpy() function omits certain characters due to the length restriction. This closes #453.
1 lines of code changed in 1 file:
* mui/WriteWindow.c: fixed the placeholders of a debug statement.
1 lines of code changed in 1 file:
* mui/MailTextEdit.c: added quotes to codeset names.
2 lines of code changed in 1 file:
* YAM.c, YAM_MA.c, YAM_UT.c, mui/MainFolderListtree.c, mui/MainWindow.c:
the folder listtree sorting will now also be automatically saved when
the new SaveLayoutOnQuit option is turned on (which is the default). In
addition, the folder listtree order/sorting will now also be saved when
using the MUI snapshot feature. This change also renders the manual
menu and context menu entries/functionality for saving and reloading
the order obsolete. Thus they have been removed. This closes #284.
8 lines of code changed in 6 files:
* *.c,*.h: replaced all real tabs by two spaces throughout the whole
repository. In addition, a pre-commit hook will now also take care that no
real tabs can be checked in any *.c,*.h,*.l,*.sd file anymore.
2381 lines of code changed in 16 files:
* tcp/pop3.c, tcp/smtp.c: changed the respective receive and sent functions
of the pop3 and smtp routines to store mails in the respective mail store
folder based on the folder id stored. This closes #400 and thus should
allow to configure different 'Incoming' and 'Sent' folders for each
POP3 and SMTP account. As a net result this should allow to sort mails
based on the accounts in different folders.
27 lines of code changed in 2 files:
* mui/FolderRequestPopup.c: omit a warning for folder IDs equal to zero.
3 lines of code changed in 1 file:
* Config.c: let the debug build omit a warning about an unresolvable sent folder if there is none configured for a user identity.
4 lines of code changed in 1 file:
* Config.c: fixed some debug output.
3 lines of code changed in 1 file:
* mui/FolderEditWindow.c, mui/MainFolderListtree.c: removed some unneeded #include statements.
0 lines of code changed in 2 files:
* mui/SearchMailWindow.c: replaced the list of selected folders by a simple array. The plan is to eliminate the duplicate allocations for folders and folder nodes later.
19 lines of code changed in 1 file:
* Config.c: dropped the support for YAM 1.x style folder definitions. If someone really updates to YAM 2.x after more than 15 years then an interim update to YAM 2.8p1 is required before finally updating to YAM 2.9 if the old folders are to be kept.
7 lines of code changed in 4 files:
* rexx/getselected.c: added a missing brace.
1 lines of code changed in 1 file:
* rexx/getselected.c: fixed a possible NULL pointer access;
7 lines of code changed in 1 file:
* Config.c: added debug output for unknown filter keywords.
2 lines of code changed in 1 file:
* mui/FolderRequestPopup.c: added some debug output when resolving a folder ID fails.
3 lines of code changed in 1 file:
* YAM_FO.c: removed a debug statement.
0 lines of code changed in 1 file:
* Config.c: fixed a wrong keyword for the destination folder of a filter's "move to" action when loading the configuration.
1 lines of code changed in 1 file:
* Config.c: added some more debug output to the folder resolve process.
33 lines of code changed in 1 file:
* Config.c: don't save folder names anymore now that we have unique folder IDs.
4 lines of code changed in 1 file:
* Config.c, YAM_FO.c, YAM_MAf.c: use the strtoul() function instead of the strtol() function when having to parse hexadecimal strings to numbers to avoid numerical errors due to too large numbers.
17 lines of code changed in 3 files:
* YAM_FO.c, Config.c, FolderList.c, misc: each folder now gets a unique ID assigned. In the future everything will be changed to reference folders by this ID only instead of referencing them by name, path or type. This will eventually make it possible to have equally named folders in different paths. This refs #400 and also refs #50.
594 lines of code changed in 21 files:
* MailServers.c, UserIdentities.c: use the translated folder names rather than the internal names as these can be resolved more precisely later.
5 lines of code changed in 2 files:
* mui/YAMApplication.c, misc: modified the MUIM_Application_ShowHelp method to
also consider the language code so that upon pressing the HELP key YAM will
open an URL which will point to an eventually translated documentation page
rather than always pointing to the english documentation pages only. In
addition, as the documentation had been updated lately all MUIA_HelpNode
uses had been updated to point to their correct documentation pages on our
yam.ch wiki.
* locale: added a two-character language code to all catalogs (except english)
which is synchronized to our supported documentation languages on our wiki
pages (https://yam.ch/wiki/TracLanguages). This will allow to popup the
online documentation localized rather than always pointing at the english
version of the documentation (given a page had been translated already).
36 lines of code changed in 12 files:
* mui/TCPIPConfigPage.c, misc: added a FolderRequestPopupObject to the POP3
and SMTP config pages to allow to set an alternative incoming and sent
folder. This refs #400. Please note, that the functionality is yet not being
used in YAM as we first have to change the way folders are referenced within
YAM.
118 lines of code changed in 7 files:
* mime/base64.c: the output buffer for the decoding was always one byte too small to keep the terminating NUL byte. This always went unnoticed even when running tools like Wipeout/Mungwall if the length of the source string was not a multiple of 8. In this case the granularity of AmigaOS' memory system shadowed this buffer overrun. Only for source strings with a length being an exact multiple of 8 bytes the buffer overrun eventually really happend. This closes #449.
1 lines of code changed in 1 file:
* YAM_MAf.c: use a temporary folder structure during rebuilding a folder's index. This saves lots of semaphore obtain/release action and should reduce the rescan time of big folders a bit.
243 lines of code changed in 1 file:
* YAM_MAf.c, YAM_UT.c: make sure to have a loaded and valid folder whenever a mail is to be added or removed from a folder. Otherwise it might happen that the corresponding mail file is moved somewhere else, but the index entry stays in the former folder. This closes #445.
187 lines of code changed in 2 files:
* Config.c: fixed the wrong signature duplication now that dynamic strings are used.
2 lines of code changed in 1 file:
* mui/SearchControlGroup.c: replaced some more TABs by spaces.
2 lines of code changed in 1 file:
* Signature.c: use the imported signature string as a dynamic string instead of copying it around a second time.
3 lines of code changed in 2 files:
* YAM_MAf.c: exploit the fact the the header content string is a dynamic string and the length can be obtained in an optimized fashion.
5 lines of code changed in 1 file:
* mime/rfc2047.c: use appropriate upper and lower case values instead of converting characters using tolower().
3 lines of code changed in 1 file:
* mime/rfc2047.c: use strlcpy() instead of memcpy() plus an artificial NUL termination to copy strings.
8 lines of code changed in 1 file:
* misc: replaced some TAB characters by spaces.
58 lines of code changed in 16 files:
* YAM.c, YAM_MA.c: the relayout must be done outside MA_New() as it requires the global variable to be initialized correctly.
3 lines of code changed in 2 files:
* YAM_MA.c, mui/MainWindow.c: integrated the setup of the embedded read pane into the main window's Relayout method as these two actions are always done in a sequence anyway.
71 lines of code changed in 5 files:
* YAM_FI.c: don't delete single rules with an empty match string, because YAM's filter must have at least one rule.
7 lines of code changed in 1 file:
* Config.c, YAM_FI.c: implemented a function to remove filter rules with empty match strings as such rules can never match any comparison.
79 lines of code changed in 3 files:
* mui/FiltersConfigPage.c: removed an unused method.
1 lines of code changed in 1 file:
* mui/SearchControlGroup.c: fixed a too small array.
6 lines of code changed in 1 file:
* mui/SearchControlGroup.c: added some constants for easier object reference.
52 lines of code changed in 1 file:
* extrasrc/AllocSysObject.c: added some debug output to FreeSysObject() to catch possible memory leaks when trying to free message ports with pending messages or non-empty lists.
43 lines of code changed in 1 file:
* misc: replaced all RemHead() based list cleanups by calls of the SafeIterateList() macro plus an additional NewMinList() call. This avoids the constant relinking of the remaining nodes for a list that is freed in most cases right after the cleanup anyway. The NewMinList() is just done for completeness reasons and to ensure that we don't access no longer existing nodes by accident.
75 lines of code changed in 14 files:
* mui/FiltersConfigPage.c: fixed a possible memory leak and invalid pointer access after removing either all or the last filter entries.
1 lines of code changed in 1 file:
* mui/YAMApplication.c: removed some unneeded debug output.
0 lines of code changed in 1 file:
* Config.c: clear the complete config before clearing the individual sections to avoid inter-section dependencies.
9 lines of code changed in 1 file:
* YAM.c, Config.c: obtain the system codeset in the main() function instead of when validating the configuration.
5 lines of code changed in 2 files:
* Config.c: fixed the loading of pre-2.9 filter definitions to not create an additional empty condition.
30 lines of code changed in 1 file:
* mui/FiltersConfigPage.c: clear the condition list in case there is no filter defined.
6 lines of code changed in 1 file:
* mui/FolderEditWindow.c: remember the newly added tree nodes to avoid a crash when deleting that new folder immediately again due to a NULL pointer access.
2 lines of code changed in 1 file:
* mui/MainFolderListtree.c: move some pointer accesses after the ENTER() statement.
6 lines of code changed in 1 file:
* YAM.c, YAM_UT.c, mui/QuickSearchBar.c: reworked the handling of the remembered quick search bar view options to correctly restore the former setting after restarting YAM.
38 lines of code changed in 4 files:
* mui/MainMailListGroup.c: made the class more robust against certain method calls before the main window is opened.
71 lines of code changed in 1 file:
* QuickSearchBar.c: added a NULL pointer check for a valid folder. This closes #446.
1 lines of code changed in 1 file:
* mui/AddressBookListtree.c: coorected the message variable type.
1 lines of code changed in 1 file:
* mui/AddressBookWindow.c: fixed the wrong activation of some objects when the active list entry changes.
3 lines of code changed in 1 file:
* mui/AddressBookWindow.c: fixed the wrong initial state of some objects after opening the window.
1 lines of code changed in 1 file:
- minor indentation fixes and made sure to really
permanently save the GUI layout
3 lines of code changed in 2 files:
* YAM.c, mui/StartupQuitConfigPage.c, mui/YAMApplication.c: implemented a new option to trigger a snapshot action on all alive windows and to save the layout/state of certain groups and objects. This closes #410.
72 lines of code changed in 5 files:
* mui/QuickSearchBar.c: added a unique ObjectID to the view options cycle object. This makes it possible to permanently save the current settings by snapshotting the main window. This refs #284.
2 lines of code changed in 1 file:
* mui/misc: changed the spacing of some popobject like object combinations.
7 lines of code changed in 7 files:
* YAM_WR.c: write the X-YAM-MailAccount: header line for sent mails, too.
6 lines of code changed in 1 file:
* MainMailList.c, YAM_MAf.c, tcp/pop3.c, misc: implemented a new
"Mail Account" column in the main mail list which will show the mail
account as "username@hostname" over which the particular mail had
been transferred. This new column should allow to sort emails based
on mail account/hostname a mail was received so that users can better
order their mails due to the fact that since YAM 2.8 mails are now
transferred asynchronously from multiple servers and thus mails from
different mail accounts end up mixed in the incoming folder.
This closes #230.
80 lines of code changed in 7 files:
* MUIObjects.c: set the usual button frame and background for the close button. Depending on the image being used MUI will ignore these settings automatically.
3 lines of code changed in 1 file:
* mui/WriteWindow.c: reverted the last change. It was a very silly idea.
0 lines of code changed in 1 file:
* mui/WriteWindow.c: remove explicitly saved draft mails, too, if composing the mail is canceled.
6 lines of code changed in 1 file:
* mui/WriteConfigPage.c: make the keyword string object the active one if nothing has been entered yet.
9 lines of code changed in 1 file:
- lets use MUIX_B instead of \033b
2 lines of code changed in 1 file:
* mui/WriteConfigPage.c: slightly modified the layout again by moving the add/remove keywords buttons below the list and right of the string objects.
8 lines of code changed in 1 file:
* mui/AttachmentKeywordList.c: make newly added keywords the active entry.
1 lines of code changed in 1 file:
* MUIObjects.c: add close buttons to the cycle chain.
1 lines of code changed in 1 file:
* MUIObjects.c, mui/WriteWindow.c: make use of MUI4's close button image to create a graphical button rather than a textual.
32 lines of code changed in 4 files:
* misc: changed all possible DisplayBeep(NULL) calls in YAM to actually refer
to a screen pointer using "_screen(obj)" instead. This should be more polite
instead of beeping all open screens.
10 lines of code changed in 6 files:
* mui/WriteConfigPage.c: slightly tuned the config gui layout for the new
attachment reminder functionality.
51 lines of code changed in 1 file:
* mui/WriteConfigPage.c: disable the complete listview object instead of the list only.
14 lines of code changed in 1 file:
* mui/CodesetPopupList.c: removed no longer required warning.
0 lines of code changed in 1 file:
* mui/MailTextEdit.c, mui/WriteWindow.c: use the latest includes of TextEditor.mcc. The keyword string is now generated on the fly from the internal MIME type list and the localized keywords.
60 lines of code changed in 2 files:
- minor fix of the IndexOfUserIdentity() function where the result was not
correctly set in case no user identity was found.
2 lines of code changed in 1 file:
* mui/WriteConfigPage.c: set a fixed height for the keyword list.
1 lines of code changed in 1 file:
* Config.c: removed the list of static attachment keyword extensions. This list will be generated on the fly from the internal MIME type list later.
1 lines of code changed in 1 file:
* mui/WriteWindow.c: simplified the creation of some buttons.
11 lines of code changed in 1 file:
* mui/WriteConfigPage.c: integrated the attachment keyword list in the config window.
91 lines of code changed in 3 files:
* mui/WriteWindow.c: rephrased the attachment reminder message.
7 lines of code changed in 1 file:
* mui/WriteWindow.c: don't pop up the attachment reminder a second time if the user has chosen "remind me later" already. This check will be done when preparing the mail for sending.
1 lines of code changed in 1 file:
* Config.c, mui/AttachmentKeywordList.c, mui/AttachmentKeywordWindow.c, mui/MailTextEdit.c, mui/WriteWindow.c: implemented an interactive attachment reminder feature as known from Thunderbird. If enabled and the user types in certain keywords from a user definable list and no attachment has been added to the mail a reminder will be shown to inform the user that an attachment might be desired. This requires the not yet released version 15.42 of TextEditor.mcc. This closes #317.
727 lines of code changed in 10 files: