February 2005 Commit Log

Number of Commits:
85
Number of Active Developers:
4
damato 2005-02-28 23:24 Rev.: 1788

- classes/Recipientstring.c: slightly restructured/cleaned up.

42 lines of code changed in 1 file:

damato 2005-02-28 23:15 Rev.: 1787

- YAM_FI.c, YAM_MAf.c, ReadMailGroup.c: replaced all v45+ only NewMinList()
usages by NewList() equivalents.

3 lines of code changed in 3 files:

damato 2005-02-28 23:14 Rev.: 1786

- YAM_utilities.h: put back <time.h> inclusion as it is required for
the GetDateStamp() prototype.

1 lines of code changed in 1 file:

damato 2005-02-28 23:13 Rev.: 1785

- YAM_global.c: reverted the USED_VAR usage for the static $STACK
string as discussed.

1 lines of code changed in 1 file:

gnikl 2005-02-28 19:06 Rev.: 1783

Move platform section infront of version stuff to have $STACK first.

24 lines of code changed in 1 file:

gnikl 2005-02-28 19:01 Rev.: 1782

Removed silly USED_VAR uses.

5 lines of code changed in 1 file:

gnikl 2005-02-28 18:40 Rev.: 1779

(StrTok_R): Replace argument 'brk' with 'sep'.

1 lines of code changed in 1 file:

gnikl 2005-02-28 18:22 Rev.: 1778

Change arguments for TC_Start() from ULONG to int.

2 lines of code changed in 2 files:

gnikl 2005-02-28 18:18 Rev.: 1777

(MA_GetAddress): Cleanup after CManager removal.

39 lines of code changed in 1 file:

gnikl 2005-02-28 18:00 Rev.: 1776

FI_GenerateListPatterns:
Use sizeof() for buffer handling.
Replace calloc with malloc().

8 lines of code changed in 1 file:

gnikl 2005-02-28 17:43 Rev.: 1775

(FI_MatchListPattern): Use "SearchPatternNode".
(FreeSearchPatternList): Likewise.

2 lines of code changed in 1 file:

gnikl 2005-02-28 15:50 Rev.: 1774

make YAM_global.o the first object linked to place $STACK into the first 1024
bytes of hunk to allow automatic stackallocation through shell v45 or later.

5 lines of code changed in 4 files:

gnikl 2005-02-28 15:37 Rev.: 1773

rcptok: Make STATIC.

1 lines of code changed in 1 file:

gnikl 2005-02-28 15:34 Rev.: 1772

OM_NEW: Fix argument to MUIA_Toolbar_Description.
NewMail: Don't construct array on declaration.
GrabSenderAddress: Likewise.

14 lines of code changed in 1 file:

gnikl 2005-02-28 15:23 Rev.: 1771

removed dead assignments

5 lines of code changed in 3 files:

gnikl 2005-02-28 15:15 Rev.: 1770

remove unused CManager stuff

4 lines of code changed in 3 files:

gnikl 2005-02-28 14:50 Rev.: 1769

update for new classes

15 lines of code changed in 1 file:

damato 2005-02-28 02:40 Rev.: 1767

- classes/ReadMailGroup.c: regrouped the attachmentgroup object into a separate
vertical group with the MailTextObject. This should slightly improve the
way YAM is weighting the attachmentgroup if the balance objects are moved
around.

18 lines of code changed in 1 file:

damato 2005-02-28 02:25 Rev.: 1766

- misc: replaced all isspace() usages by calls to our own ISpace() macro.

10 lines of code changed in 5 files:

damato 2005-02-28 02:05 Rev.: 1764

- extrasrc/stpblk.c: replaced all stpblk() function usages by TrimStart() calls
as these two function are totally redundant.

10 lines of code changed in 9 files:

damato 2005-02-28 01:27 Rev.: 1761

- YAM_RE.c, YAM_read.h: fixed bug #1074783 where overlong MIME boundary
header lines caused an internal buffer to overrun which in fact caused
YAM to either do weird things or even crash entirely.

12 lines of code changed in 2 files:

damato 2005-02-28 01:03 Rev.: 1760

- YAM_RE.c: The temporary filename generation was still not as unique as I
thought before. Hopefully now each unique readmail operation will trigger
an unique temporary file generation.

4 lines of code changed in 1 file:

damato 2005-02-28 00:40 Rev.: 1759

- misc: replaced the whole "struct Data2D" usages by proper exec list usages.
The formerly used structure including the AllocData2D/FreeData2D calls was
way too error prone and uncommon to handle such two dimendional data. Please
note that the main use of "struct Data2D" was the management/parsing of
mail header lines which was done in a single global variable throughout
the whole YAM application. After dropping the whole "struct Data2D" stuff
now each mail part contains its own private header list which should make the
parsing routines more safe and probably also a bit faster was we don't have
to parse the headers out of files multiple times before displaying them to
the user. Also future multithreading capabilities should not have to worry
about that global variable anymore.

851 lines of code changed in 11 files:

damato 2005-02-24 23:07 Rev.: 1758

- YAM_global.c: fixed library base definitions by separating them due to
the different target platforms. The recent YAM_utilities.h change broke
the OS4 build due to an incorrect IntuitionBase definition.

53 lines of code changed in 1 file:

krille 2005-02-24 14:31 Rev.: 1755

Add intuition proto to fix SAS/C build.

1 lines of code changed in 1 file:

damato 2005-02-23 01:16 Rev.: 1753

- YAM_WR.c: slightly updated MIME warning message to suggest Thunderbird for
all platforms in favour of i.e. Eudora, because it might be better to
suggest another GPL flavoured client that is quite common ;)

2 lines of code changed in 1 file:

damato 2005-02-23 00:17 Rev.: 1752

- YAM_RE.c: forgot to clear the PGP signed/encrypted flags of a readmaildata
structure in the CleanupReadMailData() function which caused that even no
PGP mails got scanned for a signature upon mail switching.

6 lines of code changed in 1 file:

damato 2005-02-23 00:15 Rev.: 1751

- classes/ReadMailGroup.c: fixed bug in the PGP signature checking functions
where the readmailgroup object was passed to the MUI_Request() function
instead of the window of that group.

1 lines of code changed in 1 file:

damato 2005-02-22 23:44 Rev.: 1750

- just killing some debug output.

0 lines of code changed in 1 file:

damato 2005-02-22 23:27 Rev.: 1749

- YAM_MAf.c: fixed bug #681110 where an CC: or BCC: header still triggered
the mail to show up as a multiple receipient mail even if it contained
no real receipient at all.

39 lines of code changed in 1 file:

damato 2005-02-22 10:57 Rev.: 1748

- classes/Addrmatchlist.c: fixed bug #805686 where SetAttr() was used on
some window tags while the window was open and therefore caused that
the adrrmatchwindow did not always follow the main window positions.

24 lines of code changed in 1 file:

damato 2005-02-21 02:13 Rev.: 1747

- YAM_WR.c, YAM_CO.c, YAM_COg.c, YAM_MA.c, misc: added two new expansion
patterns "%c" and "%z" for the reply/forward mail quotation operations.
While %z will just print out the timezone in a common format (+0000),
the %c pattern will print out the whole RFC2822 conform date&time string
of the original mail header.

139 lines of code changed in 9 files:

damato 2005-02-21 01:49 Rev.: 1746

- just some more comments

3 lines of code changed in 1 file:

damato 2005-02-20 22:13 Rev.: 1745

- YAM_RE.c: fixed bug #1109409 and #1144691 where YAM did issue a
MUI_DisposeObject() on a read window directly instead of using
MUIM_Application_PushMethod which caused crashes under certain
circumstances.

5 lines of code changed in 1 file:

damato 2005-02-20 17:25 Rev.: 1744

- minor change so that due to proportional fonts no char gets cut.

5 lines of code changed in 1 file:

damato 2005-02-20 17:13 Rev.: 1743

- YAM_CO.c, YAM_MI.c, misc: implemented a system default charset
recognition method where YAM will try to check the configured charset
of the system it is running on and compares it to the LocalCharset
settings of the YAM configuration. If YAM then finds out that the
system charset doesn't match the localcharset it will put up a warning
requester where the user can choose to either change the local charset
or ignore the requester.
However, please note that a proper system charset identification is only
fully implemented in AmigaOS4. On all other platforms YAM will try
to find a CHARSET environment variable which contains the currently
active charset of the system.

91 lines of code changed in 6 files:

damato 2005-02-20 15:03 Rev.: 1742

- YAM_MI.c: fixed bug where the source charset specification was used
in the RFC2047 encoding routines, instead of the destination charset
which fixes bug #1107821

4 lines of code changed in 1 file:

damato 2005-02-20 14:48 Rev.: 1741

- YAM.c: the "mark new mail as unread" upon startup feature did still
calculate the amount of unread/new mails slightly incorrect.

0 lines of code changed in 1 file:

damato 2005-02-20 14:06 Rev.: 1740

- classes/ReadWindow.c, misc: fixed bug where YAM wasn't able to save the
vertical weights of the headerlist and texteditor group anymore.
Also revised the way YAM will save the different weights of GUI elements.
Previously YAM did save the orientation of all GUI elements upon quiting
the application. Now YAM will only save these settings if the window
is "snapshotted" via the MUI window snapshot option. So if you want to
save either the GUI elements setup in the main or read window you have
to use the MUI snapshot option instead of having to quit the whole
application to make YAM save these settings.

109 lines of code changed in 6 files:

damato 2005-02-20 00:37 Rev.: 1739

- classes/AttachmentImage&Group.c: make YAM save the diskobject of an
attachment if the attachment is dropped onto a workbench drawer.
This should also fix the notification problems/issue already reported
as bug #1138672.

20 lines of code changed in 2 files:

damato 2005-02-19 21:49 Rev.: 1738

- classes/Splashwindow.c: fixed bug #1084418 where the progress gauge
were not correctly displayed under certain situations because of
refeshing problem in the main window class of MUI.

26 lines of code changed in 1 file:

damato 2005-02-19 21:12 Rev.: 1737

- YAM_MA.c: fixed bug #1098671 where upon moving/deleting a mail through
a filter didn't update the folder statistics correctly.

11 lines of code changed in 1 file:

damato 2005-02-19 20:50 Rev.: 1736

- classes/AttachmentGroup.c: added some _mtop/_mleft checkings to make
sure no text is drawn outside our rastport. This should hopefully fix
bug #1123850

7 lines of code changed in 1 file:

damato 2005-02-19 20:28 Rev.: 1735

- YAM_RE.c: YAM was not only closing an open read window while getting
iconified, but also cleaning up the whole read mail data which results
in a lost read window after reopening the application.

12 lines of code changed in 1 file:

damato 2005-02-19 20:09 Rev.: 1734

- YAM.c: fixed bug where the amount of new mails was not correctly resetted
to unread when the UpdateNewMail feature was enabled for YAM startup
processing. Now YAM should show all folder statistics correctly after
startup.

35 lines of code changed in 2 files:

damato 2005-02-19 16:18 Rev.: 1733

- YAM_MA.c, YAM_RE.c, ReadWindow.c: fixed bug where YAM didn't close an
open read window on a Delete/Move operation even if no mail was left in
the corresponding folder. Now YAM should close the read window after the
last mail has been deleted/moved out by the user.

45 lines of code changed in 2 files:

damato 2005-02-19 16:12 Rev.: 1732

- DisplayStatistics calls weren't correctly ordered.

2 lines of code changed in 1 file:

damato 2005-02-19 16:05 Rev.: 1731

- forgot to put some credits for the two new classes as we have taken large
portions of code from SimpleMail. thanks sba! :)

12 lines of code changed in 2 files:

gnikl 2005-02-17 12:41 Rev.: 1730

Add workaround for NDK nuisance.

10 lines of code changed in 1 file:

damato 2005-02-17 10:06 Rev.: 1729

- YAM_utilities.h: reverted the evaluation of the return value of GetAttr()
as part of our xget() inline function. It seems that with some attributes
(e.g. MUIA_Selected) MUI always returns FALSE. However, setting b=0
right before the GetAttr() call should catch cases in which the attribute
really doesn't exist.

8 lines of code changed in 1 file:

damato 2005-02-17 10:03 Rev.: 1728

- minor debugging change.

1 lines of code changed in 1 file:

damato 2005-02-17 03:01 Rev.: 1727

- AttachmentGroup.c: fixed a bug where upon a mail switching the
image object weren't cleaned up correctly which caused YAM to crash if
it was brought back from an iconify state.

8 lines of code changed in 1 file:

damato 2005-02-17 01:55 Rev.: 1726

- Makefile, extrasrc/dice.c: minor changes to make YAM easier compileable
with a vanilla OS3.9 NDK.

2 lines of code changed in 2 files:

damato 2005-02-17 01:09 Rev.: 1724

- YAM_debug.h: put the NOP statements back into as there is no real reason
for not having them. They increase the security, are supported by all
common gcc versions and are anyway removed during optimization. And if
a properitery compiler doesn't support it, please do add a separate
#ifdef for that case. Just removing them for the sake of supporting
other compilers isn't an alternative.

3 lines of code changed in 1 file:

damato 2005-02-17 00:55 Rev.: 1722

- ReadMailGroup, misc: renamed all internal "Photo" ocurrances to
"Image" because that name is used all over the place in YAM for the
SenderImage.

8 lines of code changed in 4 files:

damato 2005-02-17 00:50 Rev.: 1721

- fixed a possible buffer overrun.

9 lines of code changed in 1 file:

gnikl 2005-02-16 19:12 Rev.: 1718

replace calloc() with malloc().

10 lines of code changed in 1 file:

gnikl 2005-02-16 18:50 Rev.: 1716

revert previous change.

2 lines of code changed in 1 file:

gnikl 2005-02-16 18:49 Rev.: 1715

wrap DB statement of else-case into {}

2 lines of code changed in 1 file:

gnikl 2005-02-16 18:43 Rev.: 1713

add stubs for icon+wb v44 (these should be in amiga.lib...)

8 lines of code changed in 1 file:

gnikl 2005-02-16 18:42 Rev.: 1712

use non-varargs functions and require v44 (OS 3.5) only.

4 lines of code changed in 1 file:

gnikl 2005-02-16 18:41 Rev.: 1711

use non-varargs function

4 lines of code changed in 1 file:

gnikl 2005-02-16 18:39 Rev.: 1710

revert LDLIBS change

1 lines of code changed in 1 file:

amis 2005-02-16 11:24 Rev.: 1709

Added 'image only' mode to show only from Sender Info wo other infos.

59 lines of code changed in 4 files:

damato 2005-02-16 03:30 Rev.: 1708

- increased required workbench library version to v45
- temporarly disabled the UpdateWorkbench call for MOS/OS3.

6 lines of code changed in 1 file:

damato 2005-02-16 03:17 Rev.: 1707

- AttachmentGroup, WriteAttachmentList: implemented the missing drag&drop
functionality of the new attachment images. Now a user can drag&drop
an attachment image directly into a workbench drawer (v45+ workbench)
or to an attachment listview of a write window. YAM will then
automatically export/copy the attachment in question to the selected
destination.

128 lines of code changed in 3 files:

damato 2005-02-16 03:15 Rev.: 1706

- slightly optimized/corrected the xget() function definition/implementation.

3 lines of code changed in 1 file:

damato 2005-02-15 02:06 Rev.: 1704

- misc: fixed a bug in the temporary file handling where it happened
that due to the limited way the filenames of the tempfiles were
generated, some undefined behaviour in mail handling occurred
such that the wrong attachments were opened after mail switching.

38 lines of code changed in 7 files:

damato 2005-02-14 10:40 Rev.: 1703

- YAM_RE.c, misc: slightly reworked the ReadInMessage() routines to not
show attachments inlined generally anymore because the new attachment
group is now the replacement for that. However, if the user selected
that he/she wants to display textbased attachments inlined, then YAM
still shows these attachments as before.
Also adapted the general mail flags a bit to better reflect the
different multipart types in future. However, please note that this
change required to bump the .index version to make sure all indexes
are rescanned properly.

107 lines of code changed in 7 files:

damato 2005-02-14 10:40 Rev.: 1702

- adapted makefiles to latest changes.
- added stub library inclusion of -licon and -lwb to the m68k makefile
as the latest changes require them.

8 lines of code changed in 3 files:

damato 2005-02-14 10:32 Rev.: 1698

- classes/AttachmentImage&Group: implemented two new internal MUI
custom classes for showing a separate attachment group object in
every readmail object of either the read window or the embedded
mail view. This attachment group displays images for every attachment
found in a mail. These images are either obtained with the help
of DefIcons or due to icon.library operations and dragable.
The images are clickable to select attachments for later operations
like saving, printing etc. In addition, context menus are enabled
in this group and allows to directly start these operations.
The group is implemented auto-sizable, which means that the images
for attachments are automatically grouped in columns. However, if the
space for the group doesn't fit all attachments it will automatically
be resized to make it possible to fit all attachments in the group.
In addition to the images also some rough information about the
attachments is displayed.

74 lines of code changed in 7 files:

damato 2005-02-14 10:31 Rev.: 1697

- YAM_debug.h: put some NOP ((void)0) statements in the empty
parts of our debug defines. This should fix some problems where
else branches with single debug statements caused some troubles if
YAM was compiled without any debugging turned on.

3 lines of code changed in 1 file:

damato 2005-02-06 03:42 Rev.: 1696

- UserImage.c: fixed bug #1115135 where the user image wasn't
always displayed correctly on all machines which seem to be
cause by the missing BMF_MINPLANES flag for the AllocBitMap()
call.

67 lines of code changed in 1 file:

damato 2005-02-05 18:36 Rev.: 1695

- YAM_COs.c: the checkmark status for the status delay change
wasn't saved in the .config file at all. That should be fixed
now.

16 lines of code changed in 1 file:

damato 2005-02-03 23:55 Rev.: 1693

- YAM.c: fixed a bug in the timerIO evaluation routines where the
additional CheckIO/WaitIO combo seemed to have cause that some
timer events were get lost under certain circumstances. Hopefully
the whole emitting and receiving of the timer events should be
more rock proofed now.

99 lines of code changed in 1 file:

damato 2005-02-03 23:54 Rev.: 1692

- YAM_MAf.c: slightly modified the folderlist highlighting once more.
Now YAM will not use the highlighting pen anymore and use two
different ways of highlighting folders with new and/or unreaded
mail. In fact, if a folder contains new mail the folder name will
get bold and if it just contains unread mail it will also turn
gray to signal that this folder just contain unread, not newly
downloaded mail. Also the amount of unread/new mails will be
appended to the folder name in case the corresponding column
is not turned on. This whole change should give the user a more
easy way of quickly finding out which folder carries new and unread
mail.

33 lines of code changed in 1 file:

damato 2005-02-03 23:53 Rev.: 1691

- some minor cosmetic change

2 lines of code changed in 1 file:

damato 2005-02-03 01:35 Rev.: 1689

- YAM_MAf.c, ReadMailGroup.c: fixed bug #1114873 where a multiselect
operation during an enabled embedded mail pane acted a bit
strange from a users point of view. Now YAM will clear up the
read pane in case a multiselect operation is underway.

29 lines of code changed in 1 file:

damato 2005-02-03 01:33 Rev.: 1688

- minor change.

4 lines of code changed in 1 file:

damato 2005-02-03 01:31 Rev.: 1687

- YAM_CO.c: changed the default embedded mail pane display
delay to 200ms as this might be a more reasonable value and
also renamed the option to "EmbeddedMailDelay" which should me
more intuitive.

4 lines of code changed in 3 files:

damato 2005-02-03 01:30 Rev.: 1686

- YAM_MAf.c, YAM_MA.c: slightly modified the folderlist to not
use the MUI highlight pen for signaling that a folder group
has folders with new mail in it. Also adapted the mail list
to show unread/new mails using bold text as this might be
a better approach for easily finding unread/new mail in the
list. However, lets see how users like that little change
which is similar to what Thunderbird is actually doing.

22 lines of code changed in 2 files:

damato 2005-02-03 01:29 Rev.: 1685

- YAM_UT.c, YAM_utilities.h, YAM_WR.c: renamed our properitery
strtok_r() to carry some uppercase letters so that it may not
conflict with the strtok_r() function available in newer clib2
runtime library versions. However, in future we might better
rewrite our function to carry the same function prototype than
the standard strtok_r() function.

8 lines of code changed in 3 files:

damato 2005-02-03 01:28 Rev.: 1684

- ReadWindow.c: removed another bunch of "-repeat" key definition
to prevent a continious deletion of mails by holding down the
delete key.

5 lines of code changed in 1 file:

damato 2005-02-02 01:13 Rev.: 1683

- UserImage.c: another minor change to the UserImage custom class
where the PDTM_SCALE method call has been replaced by bit a more
widely available BitMapScale() call. This should drop the
requirement of an installed picture.datatype v45. In addition
the minimum height calculation of the user image has been altered
so that it is still possible to resize the attached NList object
to its minium values. This should make the userimage fit a bit
better into the overall layout of the ReadMailGroup object.

134 lines of code changed in 5 files:

damato 2005-02-01 03:05 Rev.: 1682

- UserImage.c: fixed bug #1113084 where the proportional image
scaling routines where such "proportional". Now the user images
should be perfectly scaled taking respect of their width/height
proportion. I also tried to fix another flaw in the user image
display where a small space is displayed below the image.
However, this is currently hard to resolve and points more towards
a possible MUI bug. Lets see if we can work around it later on.

37 lines of code changed in 2 files:

January 2005 »

Generated by StatSVN 0.7.0