* Themes.c: the version of a ".theme" file will now be checked and the
user warned accordingly. In case an invalid version is found YAM will
now popup a requester and give the user the change to load the default
theme, ignore the requester or exit the application.
159 lines of code changed in 5 files:
* ImageCache.c: if an image could not be loaded via datatypes.library the
error message will only be displayed if the file exists.
2 lines of code changed in 1 file:
* YAM_MA.c: try to avoid a possible crash situation where within the
MA_DeleteSingle() function a mail was supplied which has a folder pointer
which is NULL. This should hopefully catch bug #1840608.
49 lines of code changed in 1 file:
* QuickSearchBar.c: the previous changes didn't work at all, because
MUIA_NList_Quiet is not getable.
7 lines of code changed in 1 file:
* QuickSearchBar.c: the list of found mails is now set quiet while the search
is in progress. This greatly speeds up the search.
15 lines of code changed in 2 files:
* ImageCache.c: fixed another possible memory leak in case a DT object could
be created, but the frame box had an invalid depth.
5 lines of code changed in 1 file:
* YAM_COg.c, YAM.cd, deutsch.ct: Changed the ARexx script listview in the
configuration to have a listview title like every other listview in YAM.
This should be more consistent and should make the purpose of the
listview more clear.
36 lines of code changed in 1 file:
* ThemeListGroup.c, misc: a found and valid themes directory will now be
displayed in the ThemeList within the YAM configuration. However, we still
need to finalize the theme selektion as well as the preview.
121 lines of code changed in 8 files:
* ImageCache.c: all resources must be freed ahead of HashTableRawRemove(),
because that function will clear the structure. This fixes bug #1839679.
3 lines of code changed in 1 file:
- added some comments
4 lines of code changed in 1 file:
* HashTable.c: fixed a signedness warning.
4 lines of code changed in 1 file:
* HashTable.h: added some links to the Mozilla repository since YAM's hash
tables base on those used in Mozilla Thunderbird.
9 lines of code changed in 1 file:
* ImageCache.c: when adding an image to the hash table the found entry is now
used directly instead of first looking up the image and adding it after-
wards.
63 lines of code changed in 1 file:
* Themes.c: restored the old dispose handling.
3 lines of code changed in 1 file:
* HashTable.c: removing an entry causing a collision wasn't marked as removed
and further on caused other entries to be unfindable. Also added some test
code to check some basic hash table operations.
251 lines of code changed in 2 files:
* Themes.c: fixed wrong order of status image names.
1 lines of code changed in 1 file:
- minor non-critical changes
16 lines of code changed in 1 file:
* Themes.c: cached theme images will no longer be disposed upon calling
UnloadTheme() as this seems to cause an invalidated hash table. This needs
some further investigation.
5 lines of code changed in 1 file:
* ImageCache.c: added the function DumpImageCache() to print out all image
nodes which are currently cached. This function is only available in the
debug builds.
39 lines of code changed in 2 files:
- replaced some strlcpy()/AddPart() calls against AddPath()
15 lines of code changed in 1 file:
* misc: merged the changes from the 'themes' branch back to the main trunk
as the changes seem to work quite smooth here and we want to get the new
themes system to a broader audience. However, be warned that the new
'themes' system may fail for you. So please report any issue you might find
so that we can quickly fix issues before we are going stable. So go
and copy the new "themes" directory to your YAM installation and see if
everything works and please note that this is currently work-in-progress.
1266 lines of code changed in 25 files:
* ReadMailGroup.c, YAM_RE.c: fixed bug #1836623 where YAM always searched
for sender information by comparing also the realname of the sender in
case the mail address wasn't found in the addressbook. This, however,
caused YAM to sometimes show the incorrect sender information as there
might be more than one person with the same realname. Now only the mail
address is compared as that one can be assumed to be unique.
136 lines of code changed in 3 files:
* FileInfo.c: querying the non-existance of a file/directory via
ObtainFileInfo() always failed because of the non-existance of the object.
9 lines of code changed in 1 file:
* YAM_MA.c, ReadWindow.c: fixed bug #1836134 where the ALT qualifier was
only working from within the mainwindow toolbar. Now the whole qualifier
check is unified within an extra function.
51 lines of code changed in 3 files:
* YAM_UT.c: changed AddPath() to return NULL in case the buffer would have
overflown.
9 lines of code changed in 1 file:
* YAM_UT.c, YAM_CO.c, FileInfo.c: replaced the obsolete PFExists() function
with direct calls to AddPath() and FileExists().
12 lines of code changed in 4 files:
* YAM_RE.c, ReadMailGroup.c: removed the RE_FindPhotoOnDisk() function as
it was not necessary to search for a photo file other than what was
specified by the user itself in the addressbook. This should also fix a
bug where in case the sender realname/address contained a ':' YAM was
asking to "insert a disk" for the search.
30 lines of code changed in 3 files:
* QuickSearchBar.c: minor cosmetic changes to the object layout.
4 lines of code changed in 1 file:
* YAM_WR.c: the attachment listview should now have the default background
colors assigned instead of using custom colors. This should really be the
job of the user to choose the default colors and not ours.
0 lines of code changed in 1 file:
* YAM.c: minor change to the developer warning requester text.
19 lines of code changed in 1 file:
* YAM_AB.c: fixed some minor compiler warnings.
35 lines of code changed in 1 file:
* YAM_UT.c, misc: replaced all calls to strmfp() with calls to our own
buffer overflow safe AddPath() variant. This should make the dynamic path
generation a bit safer and avoid buffer overflows. strmfp() should be
considered to be obsolete and therefore not used in YAM anymore.
111 lines of code changed in 29 files:
* NewReadArgs.c: in case YAM was started as "YAM ?" to read the template and
got send a CTRL-C while the template was displayed it will now immediately
abort, because otherwise the CTRL-C will be catched later and cause crashes.
9 lines of code changed in 1 file:
* YAM_MAf.c: now the folder being rescanned will be updated instead of the
active one.
1 lines of code changed in 1 file:
* YAM_MAf.c: as soon as a folder directory is Lock()'ed during an index
rebuild the folder listtree will reflect this state change.
6 lines of code changed in 1 file:
* YAM_MAf.c: fixed a GCC complaint about passing in a LONG for %d instead of
and int.
1 lines of code changed in 1 file:
* asprintf.c, snprintf.c, xset.c, ObtainDirContext.c: added VARARGS68K
specifier for all varargs functions where it was missing. Also adapted the
tag list passing for MorphOS for ObtainDirContextTags().
42 lines of code changed in 5 files:
* YAM_UT.c, YAM_MAf.c: added a pattern parameter to the FileCount() function
which can be used to limit the counting to certain files.
37 lines of code changed in 3 files:
* YAM_MAf.c, YAM_UT.c, ThemeListGroup.c, extrasrc.c: replaced all direct
calls to ExAll() by the new directory scanning API.
314 lines of code changed in 6 files:
* ExamineDir.c: implemented a basic emulation of the new OS4 directory
scanning API based on ExAll().
258 lines of code changed in 2 files:
* YAM_UT.c, YAM_TR.c: changed the transfer info window to only get
activated in case the parent window is active as well and not just because
it was a manual action that opened the window. This should be more
intuitive, especially because during a transfer the active window may
change due to user action and then automatically activating the infowindow
is not was a user might expect.
39 lines of code changed in 3 files:
* YAM_TR.c, YAM_UT.c: the notification window after downloading mails will
now also be activated only if the transfer was initiated by the user.
ARexx or timer initiated transfers will open an inactive window to avoid
stealing the focus from other windows.
27 lines of code changed in 3 files:
* YAM.c, YAM_MA.c, YAM_WR.c: replaced the embedded NotifyRequests by
dynamically allocated ones. On OS4 this is done via AllocSysObject() to
improve memory tracking. All other systems use simple memory allocation.
43 lines of code changed in 4 files:
* FileInfo.h: enabled isFile() and isDrawer() macros again for OS4.
0 lines of code changed in 1 file:
* misc: the GUI does now distinguish between user triggered and automatically
(i.e. timer, ARexx, etc) triggered mail transfers. The transfer window will
be opened in active state for user triggered transfers only to avoid
stealing the focus from other windows by automatic actions.
179 lines of code changed in 11 files:
* misc: moved the FileExists() function over to FileInfo.c.
34 lines of code changed in 8 files:
* FileInfo.c, FileInfo.h: added some more "documentation" comments on how to
use this new function.
24 lines of code changed in 2 files:
* YAM_UT.c, FileInfo.h, FileInfo.c, YAM_MAf.c: fixed partly broken build
where not all FileXXXX() uses were properly replaced by the new
ObtainFileInfo() function.
70 lines of code changed in 4 files:
* misc: replaces all calls to FileSize(), etc to calls to ObtainFileInfo().
303 lines of code changed in 15 files:
* FileInfo.c: added generic file information function ObtainFileInfo(), which
replaces the single functions like FileSize(), etc.
191 lines of code changed in 2 files:
* YAM_COg.c: fixed inconsistend GUI behaviour upon repeatedly (de)activating
the spam filter. This fixes bug #1829959.
43 lines of code changed in 1 file:
* YAM_UT.c, YAM_FO.c, YAM_EA.c, YAM_WR.c, YAM_COg.c: reworked the
shortcut flag logic again. Now external shortcuts must explicitly
be requested if needed (i.e. in the write window).
9 lines of code changed in 4 files:
* YAM_UT.c, YAM_FO.c, YAM_EA.c, YAM_WR.c, YAM_COg.c: reworked the
shortcut flag logic.
7 lines of code changed in 4 files:
* YAM_UT.c, YAM_FO.c, YAM_EA.c, YAM_WR.c, YAM_COg.c: address fields can now
be told to catch copy/paste shortcuts themself again in case where the
surrounding window does not handle this (i.e. the folder config window).
This fixes bug #1830039.
21 lines of code changed in 6 files:
* YAM.c: changed all the rest of the AllocPooled()/FreePooled() uses to
generally use AllocVecPooled()/FreeVecPooled() instead. In addition, the
startup semaphore locking will now not perform an own RemSemaphore() on
AmigaOS4 anymore as the FreeSysObject() function explicitly does that.
14 lines of code changed in 1 file:
* extrasrc.h, extrasrc/AllocVecPooled.c, extrasrc/FreeVecPooled.c: changed
the prototypes of the AllocVecPooled() and FreeVecPooled() wrapper functions
to use the proper Amiga-types e.g. APTR as Amiga-wrapper functions should
always use Amiga-like types.
4 lines of code changed in 3 files:
* YAM_MA.c, YAM.cd, deutsch.ct: when adding the address from a mail with
diffenent From and Reply-To addresses to the address book YAM will now ask
which address to add, and no which address to reply to. This fixes bug
#1829977.
6 lines of code changed in 1 file:
* YAM_COg.c: added missing shortcut for the "default charset" string gadget.
This fixes bug #1829952.
2 lines of code changed in 1 file:
* fixed a typo
1 lines of code changed in 1 file:
* YAM.c, YAM_rexx_rxif.c, YAM_rexx.c: now only AllocVecPooled() and
FreeVecPooled() will be used for all systems.
784 lines of code changed in 3 files:
* extrasrc/AllocVecPooled.c, extrasrc/FreeVecPooled.c: added AllocVecPooled()
and FreeVecPooled() functions for systems which don't yet have these
implemented.
75 lines of code changed in 4 files:
- fixed build of OS3 and MorphOS which was broken.
4 lines of code changed in 2 files:
* YAM.c, YAM.h, YAM_rexx.c, YAM_UT.c, YAM_rexx_rxif.c, YAM_rexx_rxif.h:
changed all own AllocVec()-MEMF_SHARED-like memory allocations to use an
own private memory pool instead of allocating memory from the global system
pool. Where appropriate we use the new AllocVecPooled() instead of
the old AllocPooled() function. In addition, the semaphore handling/setup
is now also done via AllocSysObject() on OS4.
3524 lines of code changed in 6 files:
* YAM.c, YAM_rexx.c, YAM_UT.c: converted all CreateIORequest() and
CreateMsgPort() uses into proper AllocSysObjectTags() calls on OS4. This
should allow for a better resource tracking by the OS4. Also modified the
STYLEGUIDE to mention the general use of these new system functions.
97 lines of code changed in 3 files:
* YAM_RE.c: MIME type entries with no extension strings will now no longer be
accepted while scanning for an extension.
19 lines of code changed in 1 file:
* YAM_FI.c: added somewhat more debug output to the filter functions.
137 lines of code changed in 1 file:
* YAM_RE.c, YAM.cd: in case a problem occurred during the base64 decoding
of attachments, YAM always discarded the output data in case it wasn't
printable text. Now YAM should be a bit more precise on outputing the
reason of the problem that occurred during decoding, In addition,
the output data will only bis discarded in case a file i/o error occurred.
This should fix bug #1828068 while keeping the user informed about the
minor problem.
23 lines of code changed in 1 file:
* YAM_WR.c: double clicking an entry in the attachment list will now display
that file. This fullfils feature request #1828213.
492 lines of code changed in 1 file:
* misc: replaced all occurences of %d in the debug macros by %ld to ensure
correct output of numbers on all systems.
40 lines of code changed in 10 files:
* YAM_stringsizes.h: reverted the line size change back to 1001 as 1000 is
the maximum limit according to RFC2821.
1 lines of code changed in 1 file:
* YAM_stringsizes.h: raised the line size for TCP transfers from 1001 to
1024 which results in a slightly "nicer" display for the first bunch of
transfered data of a mail.
1 lines of code changed in 1 file:
* BayesFilter.c: replaced some %d by %ld to ensure correct debug output.
Additionally a bug in the OS3 clib2 build has been fixed which caused
the log() function to return -inf for very small value even if these
values would still have resulted in a valid log calculation. This very
often made the spam recognition fail with OS3.
6 lines of code changed in 1 file:
* YAM_RE.c, ReadMailGroup.c: applied some cosmetical changes to adapt the
source to the STYLEGUIDE.
73 lines of code changed in 2 files:
* extrasrc/xset.c: now a new tag list is built from the supplied tag list
to be able to terminate this one by TAG_DONE. This requires some guess-
work and is limited to 5 attributes to be set at most with one call of
xset(). That's all what can be done to keep up SAS/C compilability if
nobody else know how to handle this case.
31 lines of code changed in 1 file:
* added svn:eol-style property
0 lines of code changed in 9 files:
* extrasrc/xset.c, extrasrc.c: added missing xset() function for compilers
which are not able to handle vararg macros. Unfortunately this function
cannot ensure the terminating TAG_DONE.
21 lines of code changed in 3 files:
* STYLEGUIDE: added a section that should renders the use of GetAttr()
and SetAttrs() obsolete and should clarify why we think the more secure
xget() and xset() macros should be used instead.
* YAM_utilities.h, misc: replaced all SetAttrs() calls by a newly
introduced xset() macro function. This macro should automatically take
care of always properly terminating a SetAttrs() call.
180 lines of code changed in 24 files:
* YAM_FO.c: fixed another unterminated SetAttrs() call.
4 lines of code changed in 1 file:
* YAM_COs.c: fixed a potential source for a crash due to an unterminated
SetAttrs() call.
4 lines of code changed in 1 file:
* YAM_MAf.c, YAM_UT.c, YAM_WR.c: the OS4 build now calls the preferred
ExamineObject() function instead of the deprecated Examine() function.
127 lines of code changed in 3 files:
* YAM_MAf.c: a search initiated by the quick search bar was not aborted if
the folder was changed during the search.
17 lines of code changed in 1 file: