* mui/AddressBookWindow.c: added new class to separate the address book GUI from the address book data structures. This class is not yet used, because the address book data structures are still far too much convoluted with the current GUI.
874 lines of code changed in 4 files:
- removed one unnecessary call to RE_ConsumeRestOfPart() for uuencoded files.
This call was just moving to the end of the file and nothing more, which seems
to be unnecessary.
1 lines of code changed in 1 file:
* mui/SpamConfigPage.c: fixed access to non-existing variable.
1 lines of code changed in 1 file:
* mui/FiltersConfigPage.c: changed the prototype of the GhostOutFilter() function to be able to use the object variable.
6 lines of code changed in 1 file:
* mui/BirthdayRequestWindow.c: added missing comma.
1 lines of code changed in 1 file:
* YAM_RE.c: removed some const qualifiers, because object pointers passed to DoMethod() cannot be assumed to be constant.
6 lines of code changed in 2 files:
* YAM_RE.c, YAM_WR.c: replaced some references to G->App by other objects.
14 lines of code changed in 2 files:
* mui/BirthdayRequestWindow.c: added a missing include statement.
1 lines of code changed in 1 file:
* mui/BirthdayRequestWindow.c, mui/FiltersConfigPage.c: replaced some references to G->App by other objects.
4 lines of code changed in 2 files:
* mui/ReadConfigPage.c: replaced some references to G->App by other objects.
6 lines of code changed in 1 file:
* mui/SpamConfigPage.c: replaced some references to G->App by other objects.
13 lines of code changed in 1 file:
* YAM_MA.c: don't the the "Forward" menu item's short cut in the main window's constructor as this is done later another time anyway while setting up all dynamic menus.
0 lines of code changed in 1 file:
* YAM_MA.c, mui/MainFolderListtree.c: call the MakeFormat method in the folder listtree's constructor rather than from the main window's.
2 lines of code changed in 2 files:
* DynamicString.c: replaced the ldiv() call by a manual division, upon special request by Jens ;)
6 lines of code changed in 1 file:
* misc: removed some unneeded include statements as we are defining MIN() and MAX() ourselves anyway. This is the 7000th commit and it is MINE!!! :)
1 lines of code changed in 6 files:
* misc: replaced several string validations by the new IsStrEmpty() macro call.
45 lines of code changed in 16 files:
* DynamicString.c: make sure that all allocations really happen with a multiple of the desired chunk size.
32 lines of code changed in 1 file:
* DynamicString.c: increased the chunk size for dynamic strings to 1024 bytes. Reason is the recent change to use dynamic string when reading mails parts. The former chunk size of 80 bytes resulted in thousands of reallocations for large attachments which made the process *very* slow.
7 lines of code changed in 2 files:
- minor debug output change
2 lines of code changed in 2 files:
* YAM_RE.c: reworked RE_DecodeStream in combination with RE_ConsumeRestOfPart
to actually use dynamic strings and first decode a stream into a dynamic
string buffer and afterwards writing it to a file instead of doing this
line by line. In addition, YAM will now also perform a codeset identification
if no codeset is supplied to RE_ConsumeRestOfPart not only for the cyrillic
codeset family.
118 lines of code changed in 1 file:
* mui/PlaceholderPopobject.c: added new class for all placeholder popup objects.
375 lines of code changed in 9 files:
* mui/MimeTypePopobject.c: added new class for all MIME type popup objects. This makes the internal handling of the open/close hooks MUCH easier.
456 lines of code changed in 6 files:
* mui/PGPKeyPopobject.c: added new class for all PGP key popup objects.
315 lines of code changed in 7 files:
- minor change
1 lines of code changed in 1 file:
* mui/CodesetPopobject.c, mui/CodesetPopupList.c: renamed two classes to better match their purpose and just to please Jens ;)
392 lines of code changed in 11 files:
* mui/CharsetPopobject.c: added new class for all character set popup objects.
318 lines of code changed in 9 files:
* YAM.c: allocate the config structure using the new AllocConfig() function.
2 lines of code changed in 1 file:
* YAM.c: added a new global variable to indicate when YAM is in its termination process.
150 lines of code changed in 4 files:
* mui/YAMApplication.c, misc: moved all subwindow related stuff (i.e. opening, closing, disposing) to the application class as it really fits better there.
129 lines of code changed in 8 files:
* Config.c: replaced some accesses to the global application object by the typical _app() macro call.
3 lines of code changed in 1 file:
* mui/MainWindow.c, mui/YAMApplication.c: moved the method to remove and dispose a window to the application class, because windows are children of the application and not of other window objects.
28 lines of code changed in 3 files:
* rexx/mailinfo.c: fixed a crash bug where strdup() was used on a NULL pointer
if a mail didn't contain any messageID. This closes #409.
1 lines of code changed in 1 file:
* YAM_FI.c, mui/FiltersConfigPage.c: removed the last warnings about an access to the old config GUI.
7 lines of code changed in 2 files:
* UpdateCheck.c, mui/ConfigWindow.c: implemented a new method to let the config window update a certain page.
18 lines of code changed in 2 files:
* mui/MainWindow.c: display the busy message a bit earlier and longer.
7 lines of code changed in 1 file:
* rexx/requestfile.c, src/Rexx.c, src/YAM_UT.c: implemented a NOICONS switch
for the REQUESTFILE Arexx command which will open the corresponding file
requester but hide and icons (#?.info files). This fulfills a long standing
enhancement request and finally closes #108.
8 lines of code changed in 4 files:
* mui/MainMailListGroup.c, rexx/listfreeze, rexx/listunfreeze.c: fixed the
LISTFREEZE and LISTUNFREEZE arexx command to make sure that no other internal
process which will use MUIA_NList_Quiet will suddenly unfreeze a list in
case the arexx command previously freezed it. Now a LISTUNFREEZE command is
mandatory or the mail list will never return from a quiet state. This finally
fixes a long standing issue and finally closes #12.
39 lines of code changed in 3 files:
* DockyIcon.c: added a missing include for the AmigaOS4 build.
1 lines of code changed in 1 file:
* Config.c: fixed a duplicate variable definition.
0 lines of code changed in 1 file:
* Config.c, mui/ConfigWindow.c, misc: separated data structure and GUI of the configuration as much as possible. This finally makes the old YAM_CO*.c files obsolete and future modifications to the config GUI should no longer trigger an almost complete rebuild of all modules using the config.
4429 lines of code changed in 111 files:
* rexx/mailinfo.c: added missing initialization of the size variable in the optional structure.
2 lines of code changed in 1 file:
* rexx/mailinfo.c: make sure that no pointer to internal variables is passed to the calling script as the mail structure might become invalid as soon as handling the ARexx command is done but the script might still access these pointers.
4 lines of code changed in 1 file:
* mui/FiltersConfigPage.c, mui/TCPIPConfigPage.c, YAM_UT.c: use a method to play the sound instead of a hook.
36 lines of code changed in 4 files:
* Rexx.c, rexx/misc: check the allocation of the optional structure and return an error upon failure. This refs #409.
31 lines of code changed in 13 files:
* rexx/mailinfo.c: use the existing FreeStrArray() function instead of doing the same stuff again and again.
6 lines of code changed in 1 file:
* YAM_MA.c, MUIObjects.c, misc: implemented use of MUIA_Window_ScreenTitle for
all windows created by YAM. This will change the title of the screen yam is
running on as soon as a window related to YAM is active. This should improve
recognition of the currently active window as the screen titlebar will then
automatically refer to YAM and thus make it possible that a user identifies
by looking at the screen title bar which application is the currently active
one. This implements and closes #414.
242 lines of code changed in 38 files:
* mui/ConfigWindow.c: added new class for the config window. This is not used yet but will eventually replace all the stuff in the current YAM_CO*.c files.
554 lines of code changed in 5 files:
* mui/WriteWindow.c: slightly adapted the write window temporary file name
pattern to use a ".txt" extension to make it more clear that the content
should be definitly readable text. In addition the window number counter
now starts with 1 instead of 0.
1 lines of code changed in 1 file:
* mui/SignatureTextEdit.c: erase all private attribute tags in OM_SET.
5 lines of code changed in 1 file:
* mui/QuickSearchBar.c: any edit operation in the quick search bar will now abort a search operation in progress. This closes #412.
12 lines of code changed in 1 file:
* mui/MainFolderListtree.c: added missing ENTER() statement.
2 lines of code changed in 1 file:
* mui/SignatureTextEdit.c: added a missing break statement which caused the signature text to be erased again immediately.
14 lines of code changed in 1 file:
* misc: removed the ENTER/RETURN macro calls from some *VERY* heavily used functions as these will blow up the size of a trace log far too much while given very little information.
15 lines of code changed in 5 files:
* mui/SignatureTextEdit.c: removed unused method.
0 lines of code changed in 1 file:
* YAM_RE.c, mui/ReadMailGroup.c, mui/AttachmentObject.c, mui/WriteWindow.c:
reworked RE_DisplayMIME() function and referenced code areas to actually
use the new Codeset information in each MIME type. Now YAM will automatically
convert the underlying MIME part data from UTF8 to the MIME-type related
codeset if the mail part in question is actually a part which contains
printable text and is thus encoded in UTF8 accordingly. This should finally
fulfill a long standing ticket and make it possible to set e.g. UTF8 as
the target codeset and YAM will not convert it at all. This closes #7.
217 lines of code changed in 6 files:
* mui/QuickSearchBar.c: changed the AbortSearch method to a simple attribute.
10 lines of code changed in 3 files:
* YAM_CO.c, mui/FiltersConfigPage.c: use the new base class for the "Filters" page. This was the last configuration page to be converted and finally renders a complete ancient and big source file superflous.
791 lines of code changed in 8 files:
* YAM_COg.c, YAM_UT.c: moved the play sound hook to a more appropriate place.
22 lines of code changed in 5 files:
* mui/MimeConfigPage.c: minor layout change.
20 lines of code changed in 1 file:
* mui/FolderRequestPopobject.c, YAM_COg.c, MUIObjects.c: added a new class for the folder request popup objects.
340 lines of code changed in 7 files:
* YAM_utilities.h, misc: implemented new "IsStrEmpty()" macro which should
replace all "if(str[0] == '\0')..." uses with "if(IsStrEmpty(str))..."
which should make the check somehwat more secure and intuitiver.
Nevertheless, we need to make use of it more widely within the source
code of YAM.
15 lines of code changed in 8 files:
* MimeTypes.c, mui/MimeConfigPage.c: a charset/codeset can now be explicitly
specified with every configurable MIME type. If not specified, the local
codeset configured in the FirstSteps section of the config will be used
for each MIME type.
91 lines of code changed in 9 files:
* MUIObjects.c, YAM_COg.c, YAM_MA.c, mui/IdentitiesConfigPage.c: moved some hooks to a more appropriate place.
68 lines of code changed in 7 files:
* YAM_CO.c: removed a now unused hook.
0 lines of code changed in 2 files:
* mui/ObjectListitem.c, mui/SearchControlGroup.c: implemented a new method to let an ObjectListitem cause its ObjectList to create and add a new instance of the class. This simplifies adding new rules to a filter.
26 lines of code changed in 2 files:
* YAM_FI.c: zero out new filters and rules.
3 lines of code changed in 1 file:
* YAM_CO.c, mui/FilterRuleList.c, mui/SearchControlGroup.c: the rule list of a filter is now rebuild from scratch each time as this makes it lots easier to maintain the list.
6 lines of code changed in 4 files:
* mui/FilterRuleList.c, mui/SearchControlGroup.c: simplified the search group object creation.
46 lines of code changed in 5 files:
* mui/SearchControlGroup.c: renamed the methods to transfer the data between rule and GUI to make their meaning more clear.
22 lines of code changed in 3 files:
* mui/WriteWindow.c: removed an unneeded include.
0 lines of code changed in 1 file:
* mui/SignatureTextEdit.c: converted a method to a simple attribute.
35 lines of code changed in 1 file:
* YAM_config.h: removed lots of no longer accessed object pointers.
18 lines of code changed in 2 files:
- fixed missing includes to get YAM compile for AROS-i386 again
3 lines of code changed in 2 files:
* YAM_RE.c, mime/uucode.c, mime/base64.c, mime/qprintable.c: modified mail
file decoding routines to always decode to UTF8 instead to the local
charset. This results in the temporary mail files to be always encoded
in UTF8 and then recoded to the local charset only when loading the text
in a texteditor object. This refs #7.
83 lines of code changed in 4 files:
* YAM_COg.c: added some warnings about accesses to the old config GUI.
2 lines of code changed in 1 file:
* YAM_CO.c, YAM_FI.c: added some warnings about accesses to the old config GUI.
3 lines of code changed in 2 files:
* MUIObjects.c, mui/MimeConfigPage.c, mui/WriteWindow.c: eleminated the direct access to the old global object list within the popup open/close hooks.
59 lines of code changed in 4 files:
* MUIObjects.c, mui/MimeConfigPage.c, mui/ScriptsConfigPage.c: eleminated the direct access to the old global object list within the ASL start/stop hooks.
126 lines of code changed in 7 files:
- use SourceLen attribute to optimized CodesetsUTF8ToStr() call
1 lines of code changed in 1 file:
* YAM_CO.c, mui/ScriptsConfigPage.c: use the new base class for the "Scripts" page.
407 lines of code changed in 13 files:
* mui/all config pages: rearranged some #include statements to avoid redefintions of MUI_Request() in the AmigaOS4 build.
37 lines of code changed in 15 files:
* YAM_CO.c, mui/MixedConfigPage.c: use the new base class for the "Mixed" page.
610 lines of code changed in 7 files:
* mui/LookFeelConfigPage.c: replaced some numbers by symbols.
4 lines of code changed in 1 file:
* mui/misc: added new definitions of column numbers to avoid having to include YAM_config.h which makes the AmigaOS4 build complain about a redefinition of MUI_Request().
38 lines of code changed in 7 files:
* YAM_CO.c, mui/LookFeelConfigPage.c: use the new base class for the "Look&Feel" page.
481 lines of code changed in 9 files:
- added missing include statement for GetHead/GetSucc
1 lines of code changed in 1 file:
- compile fix and minor compiler warning fix.
5 lines of code changed in 2 files:
* YAM_CO.c, mui/MimeConfigPage.c: use the new base class for the "MIME" page.
730 lines of code changed in 10 files:
* mui/SecurityConfigPage.c: slightly changed indentation.
33 lines of code changed in 1 file:
* mui/ReplyForwardConfigPage.c: added missing #include statement.
1 lines of code changed in 1 file:
* YAM_CO.c, mui/ReplyForwardConfigPage.c: use the new base class for the "Reply/Forward" page.
302 lines of code changed in 8 files:
* mui/ConfigPage.c, mui/IdentitiesConfigPage.c, mui/SignatureConfigPage.c, mui/TCPIPConfigPage.c, YAM_CO.c: eliminated the warnings about updates for objects on other pages by setting up a cross-page notification.
90 lines of code changed in 5 files:
* MUIObjects.c, YAM_COg.c: move the MakeVarPop() function to a more suitable place.
119 lines of code changed in 3 files:
* YAM_CO.c, mui/UpdateConfigPage.c: use the new base class for the "Update" page.
250 lines of code changed in 7 files:
* YAM_CO.c, mui/StartupQuitConfigPage.c: use the new base class for the "Startup/Quit" page.
167 lines of code changed in 7 files:
* YAM_COg.c: removed some unused prototypes.
0 lines of code changed in 3 files:
* YAM_CO.c, mui/SecurityConfigPage.c: use the new base class for the "Security" page.
213 lines of code changed in 6 files:
* YAM_CO.c, mui/SignatureConfigPage.c: use the new base class for the "Signature" page.
517 lines of code changed in 7 files:
* YAM_CO.c, mui/WriteConfigPage.c: use the new base class for the "Write" page.
245 lines of code changed in 7 files:
* YAM_CO.c, mui/ReadConfigPage.c: use the new base class for the "Read" page.
506 lines of code changed in 6 files:
* YAM_CO.c, mui/SpamConfigPage.c: use the new base class for the "Spam" page.
595 lines of code changed in 6 files:
* mui/FirstStepsConfigPage.c: added missing folding marker.
2 lines of code changed in 1 file:
* YAM_CO.c, mui/AddressBookConfigPage.c: use the new base class for the "Identities" page.
831 lines of code changed in 7 files:
* mui/AddressBookConfigPage.c: fixed wrong help node.
1 lines of code changed in 1 file:
* YAM_CO.c, mui/AddressBookConfigPage.c: use the new base class for the "Address book" page.
201 lines of code changed in 7 files:
* mui/ConfigPage.c: simplified the page header creation.
17 lines of code changed in 3 files:
* mui/ConfigPage.c: use a scrollgroup by default.
1 lines of code changed in 1 file:
* mui/SignatureTextEdit.c, mui/WriteWindow.c: changed the functionality to
open text in an external editor to actually use the new configurable
ForcedEditorCodeset. Nevertheless, substantial work is still missing to
change YAM to always use UTF8 internally.
57 lines of code changed in 2 files:
- added missing include statement
4 lines of code changed in 1 file:
* mui/TCPIPConfigPage.c: removed some debug output.
0 lines of code changed in 1 file:
* mui/ConfigPage.c: add a spacer to the scrollgroup.
3 lines of code changed in 1 file:
* YAM_CO.c, mui/TCPIPConfigPage.c: use the new base class for the "TCP/IP" page.
1291 lines of code changed in 8 files:
* YAM_CO.c, mui/FirstStepsConfigPage.c: use the new base class for the "First Steps" page.
242 lines of code changed in 8 files:
* mui/ConfigPage.c: added new base class for all config pages.
134 lines of code changed in 1 file:
* mui/SearchControlGroup.c: removed some unused code.
0 lines of code changed in 1 file:
* YAM_FI.c, YAM_MA.c, mui/MainWindow.c: implemented the apply filters hook as a proper method.
186 lines of code changed in 5 files:
* YAM_FI.c, YAM_MA.c, mui/misc: implemented the search window open hook as a proper method.
40 lines of code changed in 8 files:
* mui/misc: use notifications to keep all folder listtrees in sync with the main window's folder listtree.
43 lines of code changed in 4 files:
* YAM_FI.c, mui/SearchMailWindow.c: make use of the new mail search window class.
90 lines of code changed in 9 files:
* mui/SearchMailWindow.c: reimplemented the search window as a separate class and renamed the text search window class. This class is not yet used.
978 lines of code changed in 6 files:
* YAM_COg.c, YAM_CO.c, misc: renamed "readCharset" variable to "localCodeset"
to make its purpose more clear. Also moved its GUI config items to the
"FirstSteps" config page and moved the external editor setup options to
"Misc". Added a possibility to specify a codeset to which text should
be automatically converted to when starting an external editor. If not
set the currently configured codeset of the write window is used or the
global one set in YAMs' configuration. This should address one item of
a long standing ticket and thus refs #7.
233 lines of code changed in 20 files:
* YAM_FO.c, Themes.c, mui/FolderListtree.c, misc: make use of the new archive folder images.
71 lines of code changed in 8 files:
* YAM_MAf.c: fixed a typo.
1 lines of code changed in 1 file:
* YAM_MAf.c: explicitly specify the system's default codeset when converting the index entries to UTF8. This saves codesets.library from having to determining exactly this codeset upon each and every call. This takes the time to save the index of a folder with 20000 mails from approx. 20 seconds down to approx. 2 seconds at most again.
9 lines of code changed in 1 file:
* YAM_MAf.c: fixed a possible memory leak in case loading a folder index failed for any reason.
3 lines of code changed in 1 file:
* YAM_MA.c: fixed a wrong search for the archive folder which caused YAM to create the folder over and over again.
1 lines of code changed in 1 file:
* mui/WriteWindow.c: change SaveToFile uses to actually convert the entered
text to the target charset selected in the write window. This should fix
problems when trying to generate/send UTF8 encoded mails as they were
written to the temp file of the write window with the read encoding always.
Now YAM will compare the configured read and write charset and if they are
different a charset conversion via SaveToFile will be performed. This
hopefully fix a long standing bug and closes #7.
* mui/MailTextEdit.c: added charset conversion functionality to LoadFromFile
and SaveToFile methods which will allow to save the currently displayed
mail text in a specific target charset.
140 lines of code changed in 3 files:
* YAM_MAf.c: save an additional strlen() call since codesets.library is able to return the length of the generated UTF8 string.
3 lines of code changed in 1 file:
* YAM_COg.c: removed a duplicate initialization of the mail server and signature cycle objects.
0 lines of code changed in 1 file:
* YAM_COg.c: some more text layout changes.
24 lines of code changed in 1 file:
* YAM_COg.c: don't use a global scrollgroup for pages which mostly consist of a register group but use single scrollgroups for each page to avoid the need of too much scrolling. Also reformatted the page generation code to match the style guide.
1659 lines of code changed in 1 file:
* DynamicString.c: simplified the cookie check.
15 lines of code changed in 1 file:
* DynamicString.c: fixed some free() calls with wrong pointers.
3 lines of code changed in 1 file:
* YAM_MAf.c: fixed a potential problem with saving the index utf8 encoded
where a wrong strlen had been calculated and the NUL termination ended
up potentially incorrect when loading the index.
5 lines of code changed in 1 file:
* mui/SignatureTextEdit.c: changed EditExternally method to use OpenTempFile
instead of putting in the temporary data to a file with always the same
name.
34 lines of code changed in 1 file:
- renamed DynamicStrings to DynamicString
461 lines of code changed in 28 files:
* DynamicString.c: revised the new dynamic string functions once more to be
somewhat more compatible to the function prototypes of the standard string
functions like strcpy(). In addition, a debug cookie will now be placed
at the top of the dynamic string structure so that we can identify if a
supplied pointer is actually a dynamic string or now.
253 lines of code changed in 25 files:
* DynamicStrings.c, misc: renamed all dynamic string functions from StrBufXXX() to dstrXXX().
758 lines of code changed in 28 files:
* mui/FolderEditWindow.c: all mailing list related options will be hidden for the default and archive folders as these don't support mailing lists at all.
17 lines of code changed in 1 file:
* mui/SearchControlGroup.c: the entered search strings is now automatically cloned between the different pages. This closes #48.
28 lines of code changed in 1 file:
* YAM.c: rearranged the order of some initialization steps to be more consistent.
10 lines of code changed in 1 file:
- fixed a minor compiler warning about incorrect format spec
1 lines of code changed in 1 file:
* YAM_CO.c, mui/WriteWindow.c: the output of the external archiver command can now be redirected optionally to a console window while the archiver is running to show the progress. This closes #55.
63 lines of code changed in 7 files:
* YAM_FO.c: handle the case that the old folder directory layout already matches the new one and don't move or rename anything in this case.
23 lines of code changed in 1 file:
* YAM_MA.c, misc: implemented the Archive folder as proposed in #396. Archived mails will be moved to a folder named after the mail's original send date. The archive folders are excluded from deleting old mails automatically to make sure the mails are really archived until the user explicitly deletes them. This closes #396.
304 lines of code changed in 8 files:
* YAM_FO.c: always try create to the global "Folders" directory and not just when converting the old directory layout to the new one.
251 lines of code changed in 1 file:
* Makefile: completely fixed cross-compiler build for OS4.
1 lines of code changed in 1 file:
- fixed cross-compiler build for OS4
1 lines of code changed in 1 file:
* YAM_MAf.c: the 'moreBytes' text embedded in a folder index will now use
the UTF-8 charset so that YAM can convert it to every possible read charset
choosen by the user. This should finally fix a long standing bug when
switching charsets and seeing invalid chars in the main mail list and thus
closes #6. Please note, however, that it requires an index rescanning of
all folders.
93 lines of code changed in 1 file:
* YAM_FO.c, locale: slightly rephrased the folder format warning to not sound
too technical.
10 lines of code changed in 1 file:
* tools/mktzdata.sh, resources/zoneinfo: fixed the mktzdata.sh script to
actually generate zoneinfo files which do not take leapseconds into account.
The reason for that is, that according to POSIX leap seconds are not counted
and thus a time_t value is always a continues number instead. Now the results
of our libtz.a functions like localtime(), etc. should be essentially the same
like on any UNIX/POSIX system. The zoneinfo files had been updated accordingly
and anyone is asked to update them respectively.
2 lines of code changed in 21 files:
* Makefile: don't remove the svnrev binary in the cleanall target.
1 lines of code changed in 1 file:
* mui/SearchControlGroup.c: added some properties.
0 lines of code changed in 1 file:
* YAM_FO.c: fixed a warning.
1 lines of code changed in 1 file:
* Makefile, tools/svnrev/Makefile: fixed the native build for AmigaOS4.
9 lines of code changed in 2 files:
* YAM.h: removed a forward declaration of a no longer existing structure.
0 lines of code changed in 1 file:
* YAM_folderconfig.h: removed the no longer used global GUI structures of the old folder edit window.
0 lines of code changed in 2 files:
* mui/MainFolderListtree.c: added the missing adaption of the folder's parent folder pointer. This caused inconsistent behaviour of different folder listtrees after adding a new folder.
5 lines of code changed in 1 file:
* YAM_FO.c, misc: all folder directories will be moved to a new subdirectory named "Folders" in the user's mail directory (which defaults to YAM's program directory if not changed via ToolTypes or the user configuration) to clean up the default directory. Possibly duplicate directory names will be get a unique number appended. In the future it will not be possible anymore to select an arbitrary path for the folders, but only the directory name within the "Folders" directory. The folder's path will default to the name as shown in the folder listtree, unless it contains invalid characters for a path (i.e. a slash or a colon). This closes #222.
263 lines of code changed in 8 files:
* YAM_US.c: output the possibly modified mail dir and config file pathes after logging in a user.
2 lines of code changed in 1 file:
* YAM_utilities.h: implemented a new MoveDirectory() function to move a complete directory to another location.
1 lines of code changed in 1 file:
* YAM_US.c: output the possibly modified mail dir and config file pathes after logging in a user.
87 lines of code changed in 1 file:
* src/tools/svnrev: fixed some warnings and added the usual "all" target.
7 lines of code changed in 1 file:
- moved svnrev tool also to own subdir under src/tools and adapted
makefiles accordingly.
984 lines of code changed in 6 files:
* extrasrc/tzcode, tools/tzcode: moved the libtz code from the extrasrc
directory to the tools subdir as it is better suited there. In addition,
rather than providing prebuilt version of libtz.a the link library is now
built on-the-fly for each system with the normal build environment.
14 lines of code changed in 9 files:
* locale/YAM.cd, TZone.c, YAM.c: minor changes the the warning messages of
either the zone.tab file or the currently selected timezone information
file are missing.
7 lines of code changed in 2 files:
* TZone.c: optimized the FindNextDSTSwitch() function a bit by performing bigger date jumps in the first two iterations.
19 lines of code changed in 1 file:
* TZone.c: added a wrapper function for tzset() which checks if the corresponding location file is available in Resources/zoneinfo and outputs a warning otherwise. Additionally the existance of the zone.tab file is checked, too.
53 lines of code changed in 4 files:
* TZone.h: added a missing include statement.
2 lines of code changed in 1 file:
* Timer.c: fixed a warning about an incompatible type.
2 lines of code changed in 1 file:
* YAM_MAf.c: added proper recognition of the timezone abbreviation in a Date:
header string. Only in rare cases the TZtoMinutes() function will now be used
and the timezone abbreviation should now properly by stored in the mail
structure.
73 lines of code changed in 1 file:
* YAM_UT.c: fixed some signedness warnings.
2 lines of code changed in 1 file:
* YAM_UT.c: revised the TimeValTZConvert() and DateStampTZConvert() functions
to use a more correct algorithm for converting TimeVal/DateStamp values
from LOCAL to UTC or vice versa. Now a logic with either mktime() or
localtime() is used.
150 lines of code changed in 8 files:
* Timer.c: fixed some more misplaced address operators.
2 lines of code changed in 1 file:
* YAM_UT.c: fixed a misplaced address operator.
1 lines of code changed in 1 file:
* YAM_UT.c: now that we have finally the infrafracture to identify which gmt
offset was effecitive at a certain date+time (even DST) the TZConvert()
functions have been changed now to actually take care of that and not
simply convert DateStamp/TimeVal values according to the currently
effective gmt offset. This finally fixes a long standing flaw in the
display of time values in the main mail list and closes #10.
72 lines of code changed in 4 files:
* Timer.c, TZone.c: implemented a new TIMER_DSTSWITCH timer which takes
care that upon fired SetTZone() is called again so that TZ/DST information
is refreshed accordingly. For this to happen the PrepareTimer() and
RestartTimer() interfaces had to be changed so that an absolute time can
now also be specified so that StartTimer() now automatically calculcates
the diff time and starts the timer accordingly.
* TZone.c, YAM_CO.c: implemented SetTZone() function which does all the mess
of setting a new timezone location as the default and then querying the
tz abbreviation and gmt offset as well as finding the time when the
next DST switch happens.
* YAM_UT.c: replaced all tm2DateStamp/DateStamp2tm function with functions
tm2TimeVal/TimeVal2tm as that is actually what we need for setting up a
timer event for the DST switch recognition.
193 lines of code changed in 15 files:
* TZone.c: removed some explicit NULL pointer checks ahead of free() calls. free() is guraranteed to be NULL safe.
40 lines of code changed in 1 file:
* mui/TZoneInfoBar.c, TZone.c: added description information of a selected
timezone in the info bar. Now the parsed comments data of zone.tab will
be displayed beside the cycle gadgets and information on GMT offset and
next DST switch.
32 lines of code changed in 4 files:
* mui/TZoneInfoBar.c: for time zones with no DST switching a proper text will
now be displayed rather than an incorrect time of DST switching.
6 lines of code changed in 1 file:
* mui/TZoneInfoBar.c: remember the current timezone display so that we prevent
calling the time consuming FindNextDSTSwitch() function twice.
5 lines of code changed in 1 file:
* TZone.c: fixed a warning for the AmigaOS3 build.
4 lines of code changed in 1 file:
* mui/TZoneInfoBar.c, YAM_UT.c, TZone.c: implemented a FindNextDSTSwitch()
function that tries to store the datestamp of the next DST switch in
the supplied function argument. This function will be used to show
the datetime of the next DST switch in the config window but also to
supply that datetime later to a timer which we start to actually notify
YAM of an upcoming DST switch.
* extrasrc/tzcode: changed time_t datatype to use "long" so that the localtime()
function actually starts working as expected.
246 lines of code changed in 8 files:
* YAM_FO.c: take the result of (re)compressing a mail during a move operation from one folder to another one correctly into account.
5 lines of code changed in 2 files:
- minor cosmetic change
2 lines of code changed in 2 files:
* mui/TZoneInfoBar.c: fixed problem where tm.tm_zone was not copied while it
was still valid. Thus, the InfoBar always displayed obsolete and incorrect
timezone abbreviation information.
4 lines of code changed in 1 file:
* YAM_UT.c: fixed a warning due to a feature of more recent gcc versions.
9 lines of code changed in 1 file:
* YAM_CO.c: slightly changed some debug output.
2 lines of code changed in 1 file:
* mui/TZoneChooser.c, mui/TZoneInfoBar.c, YAM_COg.c: split off the time zone info label from the time zone chooser to make the maintainance easier.
199 lines of code changed in 6 files:
* mui/TZoneChooser.c, YAM_UT.c: added a labelInfo text to the TZoneChooser
class which will be displayed in the YAM configuration for information
purposes. In addition, a DateStamp2tm() function is now correctly converting
a struct DateStamp to struct tm and prepare it for being used with mktime().
This should fix the previously incorrect timezone/DST calculation occurring
since we introduced our own libtz functionality.
145 lines of code changed in 5 files:
- use strcasecmp() rather than stricmp() to let AROS compile properly.
7 lines of code changed in 1 file:
* misc: reduced the usage of the global application pointer to an absolute minimum. Better use the _app() macro for this.
5 lines of code changed in 2 files:
* misc: reduced the usage of the global application pointer to an absolute minimum. Better use the _app() macro for this.
103 lines of code changed in 14 files:
* TZone.c, misc: first large overhaul of the management of timezones and
where YAM is getting the GMT offset and daylight saving time (DST)
information from. Previously, YAM was trying to get both from the system
itself which only worked reliably for AmigaOS4. In addition, it was
trying to use all kind of third-party tools like SetDST, FACTS, etc.
for other systems which also made things way to complicated. Now with
this change YAM is finally using an own timezone database and
functionality based on the official tzdata/tzcode library from IANA.org
This should make timezone and DST guessing much more reliable and
less cumbersome. In addition, this new functionality will finally fix
certain flaws. Thus, this refs #10.
107 lines of code changed in 14 files:
* YAM_COg.c: replaced some usages of xget(MUIA_NList_Active) by MUIV_NList_Remove_Active to remove the active element.
4 lines of code changed in 1 file:
* mui/ReadWindowStatusBar.c: reverted the recent hook replacement, because Zune on AROS does not support the MUIM_Layout method in a compatible way.
105 lines of code changed in 1 file: