* YAM_TR.c: just a minor code cleanup
3 lines of code changed in 1 file:
* YAM_FI.c, YAM_TR.c: the number of spam classified mails will now be included
in the statistics requester after a mail download or filter operation if the
spam filter is enabled. This fulfills change request #1861290. Additionally
the statistics window will only be shown after a download if at least one
mail was not spam. This fulfills change request #1861292.
65 lines of code changed in 5 files:
* YAM_AB.c: added some comments
5 lines of code changed in 1 file:
* YAM_AB, YAM_UT.c, YAM.c: the same changes as yesterday, because my local
working copy was broken and nothing was really transferred.
460 lines of code changed in 5 files:
* classes/ImageArea.c: added missing SAS/C pragma and prototype for
WritePixelArrayAlpha().
35 lines of code changed in 1 file:
* extrasrc/xset.c: added missing cast to avoid warnings.
1 lines of code changed in 1 file:
* YAM.c: added missing CloseLibrary() call for cybergraphics.library.
1 lines of code changed in 1 file:
* locale/#?.ct, doc/#?.guide, Makefile: changed all catalog translation and
AmigaGuide file names to english names instead of translated ones. This
makes it easier to keep/add further translations which may contain
characters not displayable on some systems (like the french '?' for
example).
16 lines of code changed in 1 file:
* YAM_COg.c, YAM_FO.c, YAM_MA.c: changed some requesters to default to "no" as
answer to avoid unwanted deletion of things.
4 lines of code changed in 3 files:
* YAM_global.c: bumped version to "2.6-dev" as we have finally released the
stable 2.5 version and about to continue with 2.6...
2 lines of code changed in 1 file:
- YAM_global.c: removed "-dev" for the final stable 2.5 release.
1 lines of code changed in 1 file:
* YAM.c: bumped minimum required version of TheBar to v21.5 which is
available since today.
3 lines of code changed in 1 file:
* YAM.c, YAM_CO.c: minor adaptions to the debug output of the XPK packer
loading. Also the xpk packer list will only be iterated through in case
xpk was found at all.
26 lines of code changed in 2 files:
* YAM_COg.c: not all XPK libraries were added to the packers list because some
do not offer all flags. But since XPK is basically a packing suite all these
libs should occur in the list. This fixes bug #1855456.
10 lines of code changed in 1 file:
* YAM_COg.c: removed again some HVSpaces where they were not necessary.
0 lines of code changed in 1 file:
* YAM.c: bumped minimum required version of TextEditor.mcc to 15.25 as
that one is the very latest now.
1 lines of code changed in 1 file:
* YAM.c: bumped minimum required version for all NList-classes according
to the version in the v0.101 release.
4 lines of code changed in 1 file:
* YAM_COg.c: put all config pages on a scroll group object. This fixes a
possible crash caused by MUI itself if the screen is too small to take the
resized window in case the preview image on the Look&Feel page is too big.
Additionally this makes all pages look a bit more uniform.
691 lines of code changed in 1 file:
* YAM.c: bumped minimum required version for codesets.library and
BetterString.mcc to the latest available version.
2 lines of code changed in 1 file:
* locale/english-british.ct: added a first primilary version of a british
english translation of our internal catalog.
1 lines of code changed in 1 file:
* YAM_MA.c: in case the user wanted old mails to be deleted upon startup and
the current folder was not the trash folder, then the trash folder was not
updated after the complete cleanup process. Only a click on the trash folder
itself would immediately update the treeview item. Maybe this also fixes
bug #1822876.
16 lines of code changed in 1 file:
* YAM_MA.c: fixed bug #1851175 where removing the last mail from a folder
didn't hide the attachment group.
1 lines of code changed in 1 file:
* YAM_MA.c, YAM_WR.c, WriteAttachmentList.c: fixed bug #1851566 where
forwarding or drag&dropping a mail from a compressed folder as an
attachment ended up in having the mail attached in compressed/encrypted
form rather than in plain text.
44 lines of code changed in 3 files:
* YAM.cd, YAM_FI.c, YAM_MA.c: fixed bug #1851127 by showing two different
requester texts in case all messages or just the selected messages of
a folder should get filtered.
60 lines of code changed in 2 files:
* YAM.c: added the missing parameter for a hook call.
1 lines of code changed in 1 file:
* YAM_COg.c: removed the shortcut for the bounce and reply string field, as
the same shortcut was already used for the corresponding checkbox. This
made it impossible to control both, checkbox and string field, by keyboard
consistently. The drawback is that the string field cannot be activated by
shortcut anymore, but that already was the case for the other string fields
on that page. This fixes bug #1837543.
2 lines of code changed in 1 file:
* MainMailList.c, ReadWindowStatusBar.c: a new mail doesn't get an additional
icon for this state anymore. Instead we now have sequence like New -> Unread
-> Old/Read.
11 lines of code changed in 2 files:
* YAM_main.h: minor optimization to the status flag checking for the SPAM
status.
1 lines of code changed in 1 file:
* YAM.c, ImageCache.c: move the access to picture.datatype over to the image
cache module.
12 lines of code changed in 2 files:
* YAM.c, YAM_global.c, ImageCache.c, ImageArea.c: for OS3 the versions of
cybergraphics.library and picture.datatype are checked now upon loading
an image. With at least cybergraphics.libraqry V45 and picture.datatype
V46 the alpha channel of 32bit image can be handled and displayed correctly.
Otherwise remapped and dithered bitmaps will be used.
90 lines of code changed in 5 files:
* AboutWindow.c, ShutdownWindow.c, SplashWindow.c: the logo image is now
always taken from the default theme and the URL in the splash window is
no longer clickable.
14 lines of code changed in 3 files:
* YAM_FI.c: missing help bubble added for the "nowhere" button.
* YAM_MA.c: exchanged the positions of the "Set status to read/unread"
menu items for consistency with the popup menu.
* YAM.cd: applied the last lot of changes to the catalog despite the,
uh, "tweaks" and concurrent changes done to it. The code should be now
ready for external localization, and it only took me a week...
13 lines of code changed in 2 files:
* YAM_COg.c, YAM_COs.c, YAM.cd: the "check for updates" checkmark has been
replaced by an item in the cycler. This effectively fixes bug #1837539.
59 lines of code changed in 3 files:
* YAM.c, YAM_RE.c, YAM_UT.c: changed some more DeleteFile() calls to actually
check for equal/non-equal zero rather than using boolean operations.
7 lines of code changed in 3 files:
* YAM_UT.c: DOS functions are guaranteed to return a non-zero value on
success, but not exactly TRUE, which broke the DeleteMailDir() function. Now
the return values are just checked for being not FALSE. This fixes bug
#1847267.
29 lines of code changed in 1 file:
* QuickSearchBar.c, YAM.cd: changed the QuickSearchBar to be controlable via
keyboard shortcuts.
4 lines of code changed in 1 file:
* ImagArea.c: fixed the broken build for MOS caused by missing commas.
2 lines of code changed in 1 file:
* YAM_COg.c: fixed bug #1845233 where an incorrect list pointer caused that
the scripts parameter popup list was always empty.
9 lines of code changed in 1 file:
* YAM.cd, YAM_COg.c: rephrased some internal strings so that we take more care
about technical terms and captions and their upper/lowercase rules. In
addition, reenabled the "you will be notified..." message in the software
update configuration section as it is more intuitive and easy to grasp what
will happen and looks more nice and there is enough space.
6 lines of code changed in 1 file:
* ThemeListGroup.c: a double click on a theme entry is now the same as a click
on the "Activate" button.
1 lines of code changed in 1 file:
* classes/MainMailList.c, classes/MainFolderListtree.c: applied most of
the changes suggested in change request #588495.
29 lines of code changed in 2 files:
* YAM_COg.c, YAM_WR.c, YAM.cd: added a few missing help bubbles and applied
several changes and fixes to the catalog. Also disabled the "you will be
notified as soon as updates are available" note in the update prefs page,
this doesn't belong in the GUI.
139 lines of code changed in 2 files:
* YAM_EA.c: fixed a potential crash bug where due to a missing ABEntry
a photo can't be set to a new addressbook item.
9 lines of code changed in 2 files:
* ImageArea.c, ImageCache.c: images with an alpha channel were not able
to be properly scaled with their alpha channel. Now PDTM_SCALE is used
for those images instead of BitMapScale(). This seems to fix the
issue. However, for that to work, picture.datatype v45+ is required.
200 lines of code changed in 2 files:
* ImageCache.c: for extracting the alpha channel data from the images
we first check if the image actually has an alpha mask via the
BitMapHeader structure. This should fix the issues with 24bit image
data on AmigaOS4 and other systems.
23 lines of code changed in 1 file:
* ImageArea.c, ImageCache, AttachmentImage.c, YAM_UT.c: on AmigaOS4 we
now use BltBitMapTags() for all blit operations rather than using our
workaround function MyBltMaskBitMapRastPort() function. In addition,
ImageArea should now also scale the bitmask in case a bitmask is
present in the source data.
197 lines of code changed in 5 files:
* ImageCache.c: temporarily disabled alpha channel support for OS3 again, as
this currently seems to be not possible to handle reliably.
7 lines of code changed in 1 file:
* ImageArea.c, ImageCache.c: fixed the wrong user image drawing which could
paint the image over the object's borders.
51 lines of code changed in 3 files:
* YAM.c: changed library init code to not force to require cybergraphics
library anymore.
6 lines of code changed in 1 file:
* ImageArea.c: added WritePixelArrayAlpha() stub for the MorphOS compile
because that libcall definition doesn't seem to be part of the MOS
SDK itself.
21 lines of code changed in 1 file:
* ImageArea.c: fixed the wrong hi/truecolor blitting under OS3 and MOS.
12 lines of code changed in 2 files:
* ReadWindow.c: fixed bug #1845068 where the "Set status to" submenu
entry was setup as a top-level MenuObject rather than a MenuitemObject
which in fact seem to have caused a graphical glitch on OS3 systems.
1 lines of code changed in 1 file:
* ImageCache.c: forgot to free the 24/32bit pixel data.
12 lines of code changed in 1 file:
* misc: added alpha channel support for hi/truecolor images, like the example
AISS theme. This is not yet perfect, but at least it is a beginning...
142 lines of code changed in 5 files:
* YAM_COs.c: restoring the configuration after having changed some scripts
now properly refreshes the script listview. This fixes bug #1845235.
20 lines of code changed in 2 files:
* YAM_COg.c: the popup button for the scripts will now be disabled if the
script doesn't take any parameters. This fixes bug #1845233.
54 lines of code changed in 1 file:
* YAM_COg.c: changed the new TextObject to actually use a Text background which
should give the textobject a more intuitive contrast against the background.
1 lines of code changed in 1 file:
* ImageArea.c: removed some debug output.
0 lines of code changed in 1 file:
* misc: the status image strings for the NList objects are now dynamically
generated.
44 lines of code changed in 6 files:
* misc: fixed the broken images in the read window status bar. The old icon
definitions are no longer necessary.
144 lines of code changed in 7 files:
* misc: minor indentation and cosmetic fixes.
23 lines of code changed in 5 files:
* YAM_EA.c, ImageArea.c: fixed the scaling bug that occured whenever a new
user image was loaded.
164 lines of code changed in 2 files:
* YAM_EA.c, ImageCache.c, ImageArea.c, YAM.cd: added a button to remove a user
image. Don't know why we didn't spot this missing button earlier. Anyway,
removing a user image is supposed to remove it from the cache too, to be
able to select a different image afterwards.
88 lines of code changed in 4 files:
* YAM_COg.c, YAM_COs.c, locale/deutsch.ct: the charset popup is now bound to
a simple text object instead of a string object, since the charset must be
selected from the list of available charset and cannot be an arbitrary name.
Also added the missing shortcut for that in the german catalog.
26 lines of code changed in 3 files:
* MainFolderListtree.c, YAM.cd: fixed bug #1700670 where the folderlist
context menu didn't have a "Mark folder read" item which makes sure
that all mail in a folder is marked as read in one go.
23 lines of code changed in 1 file:
- minor cosmetic changes
5 lines of code changed in 3 files:
- for a native OS4 compile we go and force the use of the GNU
mkdir as well.
0 lines of code changed in 1 file:
* Themes.c: again modified the image name duplication process to ensure that
all toolbars get unique name pointers.
29 lines of code changed in 1 file:
* Themes.c: removed non-existing debug call.
0 lines of code changed in 1 file:
* Themes.c: finally found the memory trashing bug with custom themes. If an
image name pointer was used for one toolbar it was reused unchanged for the
other toolbars (i.e. the delete button image) eventually causing pointers
to be free()'d twice upon freeing the theme.
5 lines of code changed in 1 file:
* ThemeListGroup.c: if a theme file could not be parsed it will now be freed
again to avoid memory leaks.
3 lines of code changed in 1 file:
* YAM_mail_lex.l: fixed bug #1841389 where the mail text parser wasn't
always able to correctly extract an email address from the text.
12 lines of code changed in 2 files:
* UserImage.c, ImageArea.c, misc: merged the differences between the
internal UserImage and ImageArea class as both classes had pretty much
the very same job/purpose. Therefore the UserImage class is now obsolete.
236 lines of code changed in 5 files:
* ThemeListGroup.c, YAM_COs.c, YAM_EA.c: finalized the whole theme
functionality by enabling a user to activate/select a theme within the
look&feel configuration of YAM.
162 lines of code changed in 4 files:
* Themes.c: fixed a typical copy'n'paste bug which screwed by certain image
paths and caused crashes because of doubly freed memory.
10 lines of code changed in 1 file:
* Themes.c, ImageCache.c, ThemeListGroup.c: reworked the whole error and
warning messages used for the theme loading/processing. Now, no missing
image file should prevent YAM from immediately starting up. Only
warning messages will be triggered and also only in case no NOIMGWARNING
commandline/tooltype option was specified.
55 lines of code changed in 4 files:
* Themes.c, ImageCache.c: temporarly replaced all modal warning requesters
with calls to ER_NewError() so that a missing image/theme or error on
trying to load a theme should not interrupt the loading process. Lets
see if this is more convinient than modal dialogs (see bug #1838367).
45 lines of code changed in 3 files: