May 2007 Commit Log

Number of Commits:
118
Number of Active Developers:
2
tboeckel 2007-05-31 14:08 Rev.: 3080

* YAM_FO.c: user defined folder images had no hash table ID and hence could
never be found and displayed. Now the file name is used as ID. This fixes
bug #1728889.

2 lines of code changed in 1 file:

tboeckel 2007-05-30 12:33 Rev.: 3079

* YAM_TR.c: removed the additional update of the folder statistics for the
AppIcon again as the real "bug" was fixed by the changes done in YAM_MAf.c.

0 lines of code changed in 1 file:

tboeckel 2007-05-30 06:52 Rev.: 3078

* YAM_UT.c: the docky icon is now updated always again, because else upon
restart the wrong icon is displayed.

6 lines of code changed in 1 file:

tboeckel 2007-05-30 06:15 Rev.: 3077

* misc: reworked the ImageCache functions to use a hash table instead of a
linear list. First, this is much faster for searching the images, and
second, the images are now "indexed" by an ID string instead of the full
image file path. This is necessary for the upcoming themes management.

387 lines of code changed in 21 files:

tboeckel 2007-05-29 19:40 Rev.: 3076

* show numbers along folder names only if not equal zero.

4 lines of code changed in 1 file:

tboeckel 2007-05-29 17:59 Rev.: 3075

* YAM_MAf.c: with this final change now all hidden columns' numbers are
shown along with the folder name.

16 lines of code changed in 1 file:

tboeckel 2007-05-29 10:47 Rev.: 3073

* MainMailList.c: the disable/enable logic for the "Send" item was
reversed.

1 lines of code changed in 1 file:

tboeckel 2007-05-29 10:44 Rev.: 3072

* YAM_MAf.c: changed the display of new and unread mails once more. All
hidden columns' numbers will be shown behind the folder name now.

6 lines of code changed in 1 file:

tboeckel 2007-05-29 08:36 Rev.: 3071

* YAM_CO.c: the last fix pushed the argument in a wrong way.

3 lines of code changed in 1 file:

tboeckel 2007-05-28 21:49 Rev.: 3070

* YAM_CO.c: some popup buttons must be reenabled in another context to ensure
they are really enabled again after the corresponding ASL requester has been
closed by MUI. This fixes bug #1725800.

41 lines of code changed in 1 file:

tboeckel 2007-05-28 19:13 Rev.: 3069

* YAM_MAf.c: in case the "New" and "Unread" columns of the folder tree are
hidden the number of new and unread mails is now displayed in this way: if
new mails exist the numbers will be displayed as "folder (new/unread)". If
only unread mails exist the number will be displayed as "folder (unread)".
If neither new nor unread mails exist then only the folder name will be
displayed. This fixes bug #1725795.

1 lines of code changed in 1 file:

tboeckel 2007-05-25 13:43 Rev.: 3067

* YAM_RE.c: added the name of the unknown charset to the warning message.

1 lines of code changed in 1 file:

tboeckel 2007-05-25 10:20 Rev.: 3066

* extrasrc/vastubs.c: added some more stubs for the OS3 build in order to be
able to use clib2's libamiga.a, too, which does not include the varargs
functions used by YAM.

18 lines of code changed in 1 file:

tboeckel 2007-05-25 06:59 Rev.: 3065

* YAM_COg.c: some invocations of MUIM_MultiSet did not include the terminating
NULL pointer.

10 lines of code changed in 1 file:

tboeckel 2007-05-24 21:50 Rev.: 3063

* YAM_COs.c: the "fixed AppIcon position" checkmark was not correctly disabled
upon opening the config window.

3 lines of code changed in 1 file:

tboeckel 2007-05-24 21:20 Rev.: 3062

* BayesFilter.c: extended the debug output a little bit in case the chi2P()
function fails. Normally this should not happen, but who knows?

5 lines of code changed in 1 file:

tboeckel 2007-05-24 18:18 Rev.: 3061

* small changes according to the STYLEGUIDE.

47 lines of code changed in 1 file:

tboeckel 2007-05-24 18:17 Rev.: 3060

* Debug.c: all builds now use the same _DPRINTF() function, becase there is
absolutely no difference at all anymore.

0 lines of code changed in 1 file:

tboeckel 2007-05-24 16:44 Rev.: 3058

* Debug.c: the OS3 and MOS builds were not able to print out floating point
numbers in the debug log, because kprintf() is not able to deal with such
values. Now the same code as for OS4 is used, which utilizes vasprintf()
and finally that buffer is put out with kprintf().

7 lines of code changed in 1 file:

tboeckel 2007-05-24 10:28 Rev.: 3057

* YAM.c, YAM_MAf.c, YAM_UT.c: separated the counting of new and unread mails.
Mails are now counted according to their current state. That means a NEW
state does no longer automatically imply an UNREAD state. If YAM does
anything wrong here we will notice it now.

19 lines of code changed in 3 files:

tboeckel 2007-05-24 09:07 Rev.: 3056

* YAM_TR.c: use no specific folder for the AppIcon stats.

2 lines of code changed in 2 files:

tboeckel 2007-05-24 09:04 Rev.: 3055

* YAM_TR.c, YAM_UT.c: use the new folder stats function.

24 lines of code changed in 2 files:

tboeckel 2007-05-24 08:57 Rev.: 3054

* YAM_FO.c: added a new function which updates the statistics for a single
folder.

39 lines of code changed in 2 files:

damato 2007-05-24 02:16 Rev.: 3053

* YAM_TR.c: reworked the TR_Read(), but especially the TR_Write() function
to take care of only partially written data. Previously TR_Write() didn't
care about 'short item counts' and only did a single data transfer via
send(), rather than trying to submit all supplied data. Now it should take
care of that as well, which hopefully should fix bug #1722336.

408 lines of code changed in 1 file:

damato 2007-05-23 13:13 Rev.: 3051

* YAM_TR.c: before considering a connect() attempt to be successfull we will
now read out the socket SO_ERROR option and check if it returns an error
or if we can consider it successfull. This should make the connect()
success state checking a bit safer, especially because of the recently
introduced for the UAE bsdsocket workaround.

18 lines of code changed in 1 file:

damato 2007-05-23 12:24 Rev.: 3050

* YAM_TR.c: reworked the TR_Connect() to not issue a subsequent connect()
in case a connection succeeded the WaitSelect() state. Somehow there seem
to be partly broken bsdsocket TCP/IP stack implementations (e.g. WinUAE)
which return with an incorrect error value instead of EISCONN. This
should fix connection problems when running YAM in WinUAE's bsdsocket
implementation.
* YAM_TR.c: replaced all Errno() uses against SocketBaseTags() calls which
are documented to replace Errno() according to the bsdsocket autodocs.

92 lines of code changed in 2 files:

damato 2007-05-23 08:47 Rev.: 3049

* YAM_TR.c: minor modifications to the socket transfer routines so that a
write operation to the socket should identify a short item count and
besides a debug warning, also end up in an error, if not all requested
data could be written to the socket.

18 lines of code changed in 1 file:

damato 2007-05-22 18:13 Rev.: 3048

* YAM_FO.c: fixed a bunch of const warnings which the latest GCC 4.2.x seems
to not accept anymore.

8 lines of code changed in 1 file:

damato 2007-05-22 09:12 Rev.: 3047

* YAM_CO.c: increased the default mail warning size to 1024KB as that should
really be a sensible default value today instead of just 100KB.

1 lines of code changed in 1 file:

damato 2007-05-22 09:06 Rev.: 3046

* YAM_TR.c, YAM_config.h, misc: replaced the integer for 'TransferWindow'
and 'PreSelection' by an enum value to make the usage more clear.

54 lines of code changed in 7 files:

damato 2007-05-22 08:06 Rev.: 3045

* YAM_TR.c: whoops, the last commit from Thore seem to have broken the OS3/MOS
builds as he did revert my last changes by accident. Now my TR_IsOnline()
changes should be back again.

110 lines of code changed in 1 file:

tboeckel 2007-05-22 01:12 Rev.: 3044

* AttachmentGroup.c: whenever a formerly non-decoded mail part is decoded (for
example when saving the attachment) the group is now redrawn to show the
exact file size instead of the estimated size.

68 lines of code changed in 1 file:

tboeckel 2007-05-22 00:29 Rev.: 3043

* ImageCache.c, locale/YAM.cd, locale/deutsch.ct: added the possibility to
ignore any missing image file.

33 lines of code changed in 1 file:

damato 2007-05-22 00:23 Rev.: 3042

* YAM_RE.c: reverted the floating point size calculation as floating
point operations should be really avoided. However, by changing the order
of the division/multiplication in the calculation, the estimated MIME part
size calculation can be performed without having to worry about any value
overflow and with only a minimum precision loss.

25 lines of code changed in 1 file:

tboeckel 2007-05-21 19:36 Rev.: 3041

* division instead of multiplication

2 lines of code changed in 1 file:

tboeckel 2007-05-21 19:15 Rev.: 3040

* YAM_RE.c: the size calculation of encoded parts could overflow if the part
was larger than 20MB, because the intermediate results exceeded 2^31 in this
case. Now a double variable is used to avoid this problem.

11 lines of code changed in 1 file:

tboeckel 2007-05-21 11:40 Rev.: 3037

* ImageCache.c: if loading of an image fails but the user chose to ignore such
errors before the error requester will no longer be displayed now.

8 lines of code changed in 1 file:

tboeckel 2007-05-21 06:54 Rev.: 3035

* YAM_TR.c: the message size labels are now initialized using FormatSize()
instead of fixed size strings like "0 B". That way these strings always look
the same and don't change their general look when the transfer really
starts.

88 lines of code changed in 1 file:

damato 2007-05-21 01:18 Rev.: 3034

* YAM.c, YAM_TR.c, YAM_global.c: reworked the whole TR_IsOnline() handling
so that on AmigaOS4 RoadShow will always be queried for its system
(online) status and tell if it is usable or not. However, by using the
IOCInterface+IsOnlineCheck variable it is still possible to directly
query for a specific interface instead of a general usability query of
the underlying TCP/IP stack.

132 lines of code changed in 3 files:

damato 2007-05-20 19:23 Rev.: 3033

* YAM_TR.c: fixed the graphical jittering of the transfer gauge by
using Size_Curr and Size_Curr_Max as the basis for the gauge progress
calculation.

2 lines of code changed in 1 file:

tboeckel 2007-05-20 19:21 Rev.: 3032

* Addrmatchlist.c: the window containing the attached string object is
activated after every change of the active list entry. In case the active
change was triggered by a mouse click this reactivation avoids the focus
loss of the string object. This fixed bug #1721712.

5 lines of code changed in 1 file:

damato 2007-05-20 19:04 Rev.: 3031

* YAM_TR.c, YAM_CO.c: now that we have non-blocking socket I/O but our
TCP/IP stuff isn't yet running in an own process, the socket timeout
calculation will now be done by always performing WaitSelect() calls of
length 1s. We do this until the real, user defined timeout value is
reached. This should allows to get the GUI even more responsive and make
the 'Abort' button of the transfer window more or less instantly abort
a transfer instead of having to wait until the defined socket timeout
is reached. As a result of this change, the default socket timeout value
will now be 10s instead of 7s because the Abort button should finally
really abort immediately.

241 lines of code changed in 2 files:

damato 2007-05-20 17:00 Rev.: 3030

* YAM.c: now that BetterString.mcc 11.10 is released we make it the new
minimum version required.

1 lines of code changed in 1 file:

damato 2007-05-20 03:36 Rev.: 3029

* misc: removed some typed-punned warnings by replacing all IsMinListEmpty()
calls by IsListEmpty() equivalents. These warnings are only issues by GCC
4.1.0+ compilers which is now the new default compiler suite for the OS4
builds.

71 lines of code changed in 13 files:

damato 2007-05-19 20:42 Rev.: 3028

* YAM_TR.c, YAM_CO.c, YAM_COs.c, YAM_config.h: finally implemented the long
awaited non-blocking socket I/O routines. Now YAM should completly use
non-blocking I/O for socket connections, so it will actively set an own
timeout (default: 7 seconds) for socket operations like connect()/recv()
and send(). In practice, this should significantly improve situations where
either the TCP/IP stack wasn't ready or the connecting server wasn't
operating properly and caused YAM to totally hang during a socket operation
with no control on whether when it will timeout. Now YAM can actively
timeout after a predefined interval and return an error.instead. For the
moment this timeout is set to 7 seconds per default - however we have to
find out what will be a sensible value for most of the people. In addition,
this new non-blocking I/O allows now to set a signal break mask on which
the socket operating should be interrupted. However, until we are running
our TCP/IP stuff in an own process (which is due for 2.6) we can't use it.
But it should then allow to immediately break a socket operation in case
the user pressed the 'Abort' button.

692 lines of code changed in 4 files:

damato 2007-05-19 20:22 Rev.: 3027

* YAM.c: the imagecache cleanup will now be processed after the main
application object is disposed. This should prevent certain crashes in case
some images are still shown (e.g. in the shutdown window).

3 lines of code changed in 1 file:

damato 2007-05-18 19:58 Rev.: 3026

* YAM.c, ShutdownWindow.c: when restarting YAM, the shutdown window will not
be displayed anymore. In addition, it will only be created in case the
application isn't in iconify state.

23 lines of code changed in 2 files:

tboeckel 2007-05-18 17:11 Rev.: 3025

* YAM.c: the shutdown window is only created and opened if the application
object exists (e.g. double start of YAM), else YAM would crash.

6 lines of code changed in 1 file:

tboeckel 2007-05-18 13:51 Rev.: 3024

* QuickSearchBar.c: if no text is entered in the search string the current
search mode will be shown in italic style and with shadow color instead of
an empty string object. This feature requires the yet unreleased version
of BetterString 11.10.

16 lines of code changed in 1 file:

tboeckel 2007-05-18 11:07 Rev.: 3023

* restored old opening behaviour of the splash window.

11 lines of code changed in 1 file:

tboeckel 2007-05-18 10:59 Rev.: 3022

* YAM.c, YAM_UT.c: added a new function to free a FileReqCache structure.

31 lines of code changed in 3 files:

tboeckel 2007-05-18 10:49 Rev.: 3021

* YAM.c, ShutdownWindow.c, YAM.cd, deutsch.ct: added new shutdown window which
is shown upon shutting down YAM. Its usability will be extended in the
future. Also cleaned up some functions a bit more.

265 lines of code changed in 3 files:

damato 2007-05-18 09:54 Rev.: 3019

- let the devil in! :-)

2 lines of code changed in 1 file:

tboeckel 2007-05-18 09:43 Rev.: 3016

* added a suitable typecast to a DoMethod() call.

1 lines of code changed in 1 file:

tboeckel 2007-05-18 09:43 Rev.: 3015

* removed an unused variable.

0 lines of code changed in 1 file:

tboeckel 2007-05-18 08:55 Rev.: 3014

* misc: implemented the "filter non-spam mails again" option. If this option
is enabled and a mail is classified as non-spam all user defined filters
will be applied to this mail first. If no filter moves or deletes this mail
it will eventually be moved back to the incoming folder.

130 lines of code changed in 8 files:

tboeckel 2007-05-18 08:46 Rev.: 3013

* restored local TR_Send() prototype.

1 lines of code changed in 1 file:

tboeckel 2007-05-18 07:56 Rev.: 3012

* misc: removed several unneeded local prototypes.

287 lines of code changed in 6 files:

tboeckel 2007-05-17 10:55 Rev.: 3011

* Addrmatchlist.c: upon opening the list of matching aliases, addresses and
names has no active entry anymore. The list is activated as soon as the user
selects one entry with either mouse or keyboard. Then, after one entry has
been selected, the currently typed string is completely replaced by the
selected entry's address instead of the matching string. This way the
recipients are *always* unique and can always be resolved correctly. Address
book entries with very similar aliases, names and adresses will no longer
cause trouble in the resolve process.

20 lines of code changed in 1 file:

tboeckel 2007-05-17 10:49 Rev.: 3010

* Recipientstring.c: minor code cleanups.

108 lines of code changed in 1 file:

tboeckel 2007-05-17 10:38 Rev.: 3009

* YAM_UT.c: added some debug output while processing the zombie files.

6 lines of code changed in 1 file:

tboeckel 2007-05-16 18:21 Rev.: 3008

* YAM_MAf.c: cleaned up the display hook of the folder tree. For folders with
both new and unread mails the number of new and unread mails are now shown
correctly.

54 lines of code changed in 1 file:

damato 2007-05-15 01:52 Rev.: 3006

* YAM_TR.c, YAM.h: reworked the whole ESMTP/SMTP connection routine to
always try to connect via ESMTP to the mail server first and only
fallback to plain SMTP in case the server doesn't seem to accept the
'EHLO' command. This allows to always query the SMTP server for its
capabilities so that we can make use out of the additional ESMTP
specialities documented in RFC 1869. For example, YAM does now
automatically use the 'SIZE=' parameter to signal the server the
message size in advance so that it can immediately return if it
will accept that size or not. Also, an existing '8BITMIME' extension
allows to specify if the actual message will be transfered in 8bit
MIME or in plain 7bit ASCII. So, in case the users 'Allow8bit'
setting is found to conflict with the SMTP server capabilities an
error message will now be dropped on an SMTP connection.

222 lines of code changed in 2 files:

tboeckel 2007-05-14 19:29 Rev.: 3005

* YAM_FO.c: changed some functions to use constant parameters.

180 lines of code changed in 2 files:

tboeckel 2007-05-14 18:10 Rev.: 3004

* YAM.c: an existing folder named "spam" is now correctly converted to the
standard spam folder if the spam filter is enabled on startup. This fixes
bug #1717689.

233 lines of code changed in 1 file:

tboeckel 2007-05-14 13:09 Rev.: 3003

* YAM.c: added missing CreateFilename() calls while checking if a spam folder
already exists.

2 lines of code changed in 1 file:

tboeckel 2007-05-14 06:55 Rev.: 3002

* YAM_COs.c: upon disabling the spam filter now the former spam folder is
redrawn instead of the current folder. This makes the folder image go away
instantly instead of having to click on the old spam folder once again.

1 lines of code changed in 1 file:

tboeckel 2007-05-11 16:14 Rev.: 2999

* misc: implemented the "move non-spam mails back to incoming" feature. If
this option is enabled falsely classified spam mails which are reclassified
as "not spam" will be moved back to the incoming folder.

120 lines of code changed in 6 files:

damato 2007-05-11 08:43 Rev.: 2996

* YAM_TR.c: reworked certain sent/recv function to better comply to our
STYLEGUIDE. In addition, more added debug output should make it easier
to debug a TCP/IP session and find out why a connection terminated.

212 lines of code changed in 1 file:

damato 2007-05-11 01:00 Rev.: 2995

* ReadMailGroup.c: reworked the OM_NEW method to not allocate a temporary
struct Data but use seperate local variables instead. In addition, usual
ENTER/LEAVE pairs are added and only a single return path is used. Also
the attachmentGroup object will be only created once and then reused
accordingly where we just Show/Hide the attachmentgroup via InitChange
ExitChange pairs. This should also fix an illegal access problem which
occurred after the last changes.

151 lines of code changed in 1 file:

tboeckel 2007-05-10 21:02 Rev.: 2994

* ReadMailGroup.c: the attachment group is now handled completely dynamically
and added/removed on the fly to the window instead of simply showing/hiding
it. Maybe this fixes some old MUI3.8 bugs.

79 lines of code changed in 1 file:

tboeckel 2007-05-10 20:03 Rev.: 2993

* Recipientstring.c: if any entry in the attached address match list was
selected with the mouse instead of keyboard the string replacement failed,
because the address match list has its own window. Clicking inside another
window made the recipient string going inactive and unmarking the selection
which in sequence just inserted the new address instead of replacing the
formerly selected part. Now a marked part is remebered before going inactive
and restored before the replace operation.

25 lines of code changed in 1 file:

tboeckel 2007-05-10 20:00 Rev.: 2992

* Addrmatchlist.c: minor optimizations.

5 lines of code changed in 1 file:

damato 2007-05-10 10:49 Rev.: 2991

* YAM_TR.c: slightly reworked the TR_DownloadURL() once more to be somewhat
more compatible to RFC2616 and the "Content-Length:" usage.

11 lines of code changed in 1 file:

damato 2007-05-10 09:43 Rev.: 2990

* YAM_TR.c: the TR_DownloadURL() function will now respect the
"Content-Length:" header which is sent with a server response to a HTTP
request. If then the amount of specified content was received we will
immediately quit the HTTP download and not wait until the HTTP drops the
connection. This should e.g. lower the amount of time an UpdateCheck
requires as otherwise we are waiting for a timeout even if we have
received all necessary data.

10 lines of code changed in 1 file:

damato 2007-05-10 08:04 Rev.: 2989

* YAM_CO.c, YAM_COs.c: if 0/0 should really be an accepted value for
positioning the AppIcon, then other checks had to be changed as well. In
addition the default value for the AppIcon position will now be set to
-1/-1 so that a free positioning will be set.

3 lines of code changed in 2 files:

tboeckel 2007-05-10 06:50 Rev.: 2988

* YAM_UT.c: the position 0/0 for an icon is valid in any case, only negative
values must be converted to a "free" position.

2 lines of code changed in 1 file:

tboeckel 2007-05-10 06:46 Rev.: 2987

* YAM_COg.c, YAM_COs.c: the button to get the current icon position is now
disabled by default, too.

11 lines of code changed in 2 files:

damato 2007-05-10 00:34 Rev.: 2986

* YAM.c, YAM_CO.c, YAM_COg.c, YAM_CO.s: revised the recently introduced
AppMessage catching from workbench.library to be somewhat more compatible
to older workbench.library versions. In addition, the configuration GUI
now contains only one single config line for changing the X/Y position
of the icon as well as a new button that will automatically query the
current position of the AppIcon and put it into the corresponding gadgets
automatically.

116 lines of code changed in 6 files:

tboeckel 2007-05-09 21:48 Rev.: 2984

* YAM_CO.c: a modified status change delay is now saved, too.

123 lines of code changed in 1 file:

tboeckel 2007-05-09 21:12 Rev.: 2983

* YAM_CO.c: added a safety check to the status change delay. Value outside the
range of 1 to 10 seconds are limited accordingly.

377 lines of code changed in 1 file:

tboeckel 2007-05-09 20:55 Rev.: 2982

* AddrBookListtree.c: applied similar changes to the address book listtree as
before to the main folder listtree. This change makes the tree scrollable
again while dragging user entries.

33 lines of code changed in 1 file:

tboeckel 2007-05-09 20:34 Rev.: 2981

* YAM.c: in case YAM is running with workbench.library V43 or earlier the
am_Class field of an AppMessage may contain garbage data which could prevent
YAM from poping up its window when the AppIcon is double clicked or a file
is dropped on it.

1 lines of code changed in 1 file:

tboeckel 2007-05-08 13:34 Rev.: 2980

* YAM_COg.c, YAM_COs.c: the sender info cycle is now enabled and disabled
according to the header lines option. Also all three GUI elements should
have the correct state now after reopening the config window.

25 lines of code changed in 2 files:

damato 2007-05-08 09:03 Rev.: 2979

* YAM_MI.c: added a missing include.

2 lines of code changed in 1 file:

tboeckel 2007-05-08 07:47 Rev.: 2978

* removed some debug output.

0 lines of code changed in 1 file:

tboeckel 2007-05-08 07:35 Rev.: 2977

* misc: the AppIcon now supports the standard Workbench Snapshot, Unsnapshot
and Empty Trash methods and reacts accordingsly. Additionally the icon
position can now be specified as non-fixed.

141 lines of code changed in 7 files:

tboeckel 2007-05-07 17:56 Rev.: 2976

* YAM_COg.c: setting the header lines to "none" now disables the "wrap
headers" checkmark.

6 lines of code changed in 1 file:

tboeckel 2007-05-07 14:15 Rev.: 2975

* AttachmentImage.c: added the BMF_MINPLANES flag to all AllocBitmap() calls.
Hopefully this fixes the crashes and garbage images that some people
encountered with OS4's 32bit icons and CGX.

5 lines of code changed in 1 file:

damato 2007-05-04 18:19 Rev.: 2972

* YAM_MA.c: fixed bug #1712714 where recent cleanups broke the multiple
recipient replying and did strip all To: addresses excluding the one
one.

2 lines of code changed in 1 file:

tboeckel 2007-05-04 06:37 Rev.: 2971

* YAM_US.c, locale/YAM.cd, locale/deutsch.ct: when creating more than one
new user and the mail directories did not exist yet the error message
indicating this fact didn't contain any information which directory of
which user didn't exist. Now the error message does contain all the
information.

19 lines of code changed in 1 file:

damato 2007-05-03 09:54 Rev.: 2970

* YAM_TR.c: the workaround for the unexpected connection drop warning wasn't
completly working as it seems that the broken SMTP server implementations
in question did accept the 'QUIT' command but dropped the connection
immediately without replying with a positive status code. Now YAM will not
warn for such unresponded QUIT command sequences and therefore should
work as expected for those ugly, damn broken SMTP servers like
'smtp.gmail.com' and/or 'smtp.googlemail.com'.
* YAM_TR.c: reworked the TR_SendSMTPCmd() and TR_SendPOP3Cmd() functions to
not use any goto statements and dynamically allocated buffers as that might
end up in unfreed memory somehow. A static buffer of SIZE_LINE should be
always enough for the command and its response.

197 lines of code changed in 4 files:

tboeckel 2007-05-03 06:57 Rev.: 2969

* YAM_FI.c: removed some unnecessary prototypes and made the function
FreeSearchPatternList() static, because it is not used anywhere outside
anymore.

2 lines of code changed in 2 files:

tboeckel 2007-05-03 06:52 Rev.: 2968

* YAM_FI.c, YAM_CO.c: added new function FreeRuleSearchData() to free the
search data of a rule node.

32 lines of code changed in 3 files:

tboeckel 2007-05-03 06:41 Rev.: 2967

* YAM_CO.c: removed some unnecessary prototypes.

0 lines of code changed in 1 file:

damato 2007-05-02 23:18 Rev.: 2966

* YAM_TR.c: added an ugly, but necessary workaround for broken SMTP server
implementations like the one used by "smtp.gmail.com". It seems, that these
stupid implemenations clearly violate RFC 2821 section 4.1.1.10 by directly
dropping a connection right after the mail was successfully send via the
'DATA' command. Normally, an SMTP server must wait until the client terminates
the connection with a 'QUIT' command. However, smtp.gmail.com doesn't seem
to care about the standard which in fact caused YAM to always throw an
"connection dropped unexpectly" error when trying to send the QUIT command
string. Now, YAM will check the socket state right before trying to send the
QUIT command and in case the socket points out that the connection was
dropped, it will not try to send the QUIT command and exits immediately
without any error or warning. Again, this is ugly and not what the standard
(RFC 2821) suggests, but as long as there are stupid developers out there
not caring about rules, we are forced to introduce such damn workarounds.
This should clear bug #1711145 and #1709100.

11 lines of code changed in 1 file:

damato 2007-05-02 23:06 Rev.: 2965

* YAM_CO.c: minor compilation fix where an unknown MUI attribute creaped into
the sources.

0 lines of code changed in 1 file:

tboeckel 2007-05-02 20:43 Rev.: 2964

* YAM.c: changed a malloc()/memcpy() combination to a memdup() call.

1 lines of code changed in 1 file:

tboeckel 2007-05-02 18:37 Rev.: 2963

* YAM_COs.c: general clean up of the CO_LoadConfig() function. The variables
lastFilter, lastFilterID, lastType and lastTypeID *must* not be declared
static as they will survive a restart and eventually will point to no longer
allocated memory. On OS4 this will lead to a crash, on OS3 it may eat up
all free memory. All in all making these variables non-static and moving
them out of their previous scope fixes bug #1700013.

665 lines of code changed in 1 file:

tboeckel 2007-05-02 17:59 Rev.: 2962

* added missing include

1 lines of code changed in 1 file:

tboeckel 2007-05-02 17:58 Rev.: 2961

* removed unused variable

2 lines of code changed in 1 file:

tboeckel 2007-05-02 14:01 Rev.: 2960

* fixed a missing "mtn->" and added the usual ENTER()/LEAVE() macros.

5 lines of code changed in 1 file:

tboeckel 2007-05-02 13:19 Rev.: 2959

* YAM.c, YAM_FI.c, YAM_TR.c: replaced several handcraftet list cleanups by
calls to RemHead().

17 lines of code changed in 3 files:

tboeckel 2007-05-02 12:00 Rev.: 2958

* YAM_CO.c: use the new MIME type list free function.

282 lines of code changed in 1 file:

tboeckel 2007-05-02 11:53 Rev.: 2957

* YAM_MI.c: added a new function to free a complete list of MIME types.

26 lines of code changed in 2 files:

tboeckel 2007-05-02 09:01 Rev.: 2956

* AttachmentImage.c: all bitmaps are cleared now upon allocation. Maybe this
fixes some graphical garbage I experienced under AmiKit.

5 lines of code changed in 1 file:

tboeckel 2007-05-02 06:43 Rev.: 2955

* MainFolderListtree.c: replaced the DragReport method by NListtree_DropType.
This makes the folder tree scrollable during dragging again. Unfortunately
this reveals a bug in NListtree.mcc which will visually accept folder groups
as valid drop target, although one cannot finally drop a mail there. This
will be fixed with the next release of NListtree.mcc.

60 lines of code changed in 1 file:

damato 2007-05-02 01:21 Rev.: 2954

* ReadWindowStatusBar.c: fixed issue where the size of the font for rendering
the folder name label in the status bar wasn't respected and therefore mixed
up the layout of the label.

18 lines of code changed in 1 file:

damato 2007-05-02 00:50 Rev.: 2953

* YAM.c: added an extended help page for the NewReadArgs() call. If YAM will
now be executed from the command-line with a "?" as an option, a more
informative help page will be presented

93 lines of code changed in 2 files:

damato 2007-05-01 19:58 Rev.: 2952

* YAM_COg.c, YAM_COs.c, YAM_CO.c, AttachmentGroup.c: moved the previously
hidden "DisplayAllAltPart" config option to the public 'Read' section of
the configuration and modified AttachmentGroup/Image code to display such
'artificial' attachments with transparency. In addition, the attachment
text will now contain an "multipart/alternative" string which will be
rendered italic to demonstrate the special meaning of that MIME part.

70 lines of code changed in 6 files:

damato 2007-05-01 18:45 Rev.: 2951

* YAM_mail_lex.l: adapted the tENDSIGNATURE identifier to also identify the
end of a signature in case "_" chars are used as a message separator.

1 lines of code changed in 1 file:

damato 2007-05-01 17:25 Rev.: 2950

* YAM_mail_lex.l: another minor optimization to the soft-style recognition
routines in the flex scanner.

8 lines of code changed in 1 file:

damato 2007-05-01 17:24 Rev.: 2949

* YAM_FO.c: fixed another issue that were introduced during the last source
cleanup and here the FO_GetFolderByAttribute() ended up in an endless loop.

37 lines of code changed in 1 file:

damato 2007-05-01 12:06 Rev.: 2947

* YAM_MA.c: exchange some conflicting menu shortcuts to get V,X,C free so that
all main shortcuts in the QuickSearchBar still work as expected. This fixes
bug #1707243.

51 lines of code changed in 1 file:

damato 2007-05-01 10:33 Rev.: 2946

* YAM_mail_lex.l: soft-styled text (*bold*) which were seperated by only one
space wasn't correctly displayed in the corresponding soft-style. Now the
mail parser should correctly highlight/soft-style the text by unputtung the
last character of the previous soft-styled text.

26 lines of code changed in 1 file:

damato 2007-05-01 09:51 Rev.: 2945

* Makefile: the flex generated source files will now be compiled without the
signed/unsigned warning as the auto-generated source code contains one
reference to such an signess issue which isn't really problematic.

8 lines of code changed in 1 file:

damato 2007-05-01 09:37 Rev.: 2944

* YAM_FO.c: fixed folder image (.fimage) loading routine which were broken after
recent cleanups.

29 lines of code changed in 2 files:

tboeckel 2007-05-01 09:28 Rev.: 2943

* InfoBar.c, ReadWindowStatusBar.c: the spam folder icons were not shown due
to a wrong index check.

2 lines of code changed in 2 files:

April 2007 »

Generated by StatSVN 0.7.0