December 2006 Commit Log

Number of Commits:
75
Number of Active Developers:
2
tboeckel 2006-12-31 17:45 Rev.: 2599

* YAM_MAf.c modified MA_NewMailFile() to always return the completely resolved
path of a file.

20 lines of code changed in 1 file:

tboeckel 2006-12-31 17:45 Rev.: 2598

* YAM_UT.c: modified GetMailFile() to always return the completely resolved
path of a file.

9 lines of code changed in 1 file:

tboeckel 2006-12-22 18:21 Rev.: 2595

* YAM_WR.c: modified the tagline functions to use the read/write functions for
integer values that have been introduced for the spam filter.

84 lines of code changed in 1 file:

tboeckel 2006-12-22 16:32 Rev.: 2594

* MainWindowToolbar.c, ReadWindowToolbar.c: the "not Spam" button is now
hidden by default and the "Spam" button is disabled by default, because the
usual toolbar update process will show/hide and enable/disable the correct
buttons.

13 lines of code changed in 2 files:

tboeckel 2006-12-22 14:44 Rev.: 2593

* YAM_UT.c: a call to TransferMailFile() could accidently be handled as
success even if an error happened. Hence YAM now starts with an error
condition here which is later turned into a real success/failure code.

2 lines of code changed in 2 files:

tboeckel 2006-12-22 02:16 Rev.: 2592

* YAM_UT.c: replaced some XPK error numbers by proper constants.

14 lines of code changed in 1 file:

tboeckel 2006-12-22 02:14 Rev.: 2591

* YAM_FO.c: if xpkmaster.library is not available it now no longer possible
to select compression or encryption for a folder.

3 lines of code changed in 1 file:

tboeckel 2006-12-22 02:13 Rev.: 2590

* YAM_COg.c: the XPK popups are disabled now if xpkmaster.library is not
available.

18 lines of code changed in 1 file:

tboeckel 2006-12-21 19:30 Rev.: 2589

* YAM_MA.c, YAM_FI.c, YAM_TR.c, YAM_rexx_rxif.c: added even more NULL pointer
checks while traversing a list of mails created by MA_CreateFullList() or
MA_CreateMarkedList(). Also did some more cleanup according to the
STYLEGUIDE.

348 lines of code changed in 4 files:

tboeckel 2006-12-21 18:11 Rev.: 2588

* YAM_COs.c: forgot to check for possible NULL pointers in the list of mails
returned by MA_CreateFullList().

6 lines of code changed in 1 file:

tboeckel 2006-12-21 16:40 Rev.: 2587

* YAM_FI.c, YAM_MAf.c: a password protected folder with a yet unloaded index
was fully visible without entering a password after a mail has been moved
to it (e.g. by a filter), because MA_MoveCopy() updated the index. Now the
old load state before the move is restored and any temporarily granted free
access is also removed again. This fixes bug #1486781.

66 lines of code changed in 2 files:

tboeckel 2006-12-21 16:36 Rev.: 2586

* YAM_UT.c: adapted some functions to the STYLEGUIDE.

161 lines of code changed in 1 file:

tboeckel 2006-12-21 16:35 Rev.: 2585

* YAM_TR.c: the NEWMSG macro now also handles the case that the user's mail
directory is a "virtual" assign like "PROGDIR:" and will now resolve the
complete real path.

1 lines of code changed in 1 file:

tboeckel 2006-12-21 03:04 Rev.: 2584

* YAM_TR.c: the NEWMSG macro is now called with the full path of the new mail
file instead of just the file name. Thus a script can always access the file
even if it is located anywhere on the hard disk. This fixes bug #702564,
although this bug was partly fixed already with the introduction of the %p
placeholder.

1 lines of code changed in 1 file:

damato 2006-12-21 00:19 Rev.: 2583

* MainWindowToolbar.c: removed the BarSpacer now that only one Spam toolbar
button is shown at a time.

1 lines of code changed in 1 file:

damato 2006-12-21 00:09 Rev.: 2582

* YAM.c: bumped the minimum required version of all NList mcc classes to
make sure the most recent version is used.

4 lines of code changed in 1 file:

tboeckel 2006-12-20 22:01 Rev.: 2581

* YAM_MA.c, YAM_CO.c, MailMailList.c, ReadWindowToolbar.c: reworked the spam/
no spam buttons and menu in such a way that you only have one choice at a
time. That means a "set to spam" button or item will only be available if
the mail is either not yet classified or definitely not spam. The same
applies for the "set to not spam" buttons and items. These will only be
available if the mail has been marked as spam before. All in all this
behaviour is now fully consistent to Thunderbird. This may seem like a loss,
because before not yet classified mails could be classified as either spam
or not spam. But the way the spam filter is intended to work contradicts
this.

154 lines of code changed in 6 files:

damato 2006-12-20 11:23 Rev.: 2580

* YAM.c, YAM_UT.c: added somewhat more detailed debugging output to our
XPK routines to find out why XPK may have failed during init or
packing/unpacking.

76 lines of code changed in 2 files:

tboeckel 2006-12-19 21:04 Rev.: 2578

* YAM_AB.c: reworked CSV/TAB import again a little bit to handle quoted items
correctly. Did the same for the export to add quotes whenever the current
item contains the separating character.

262 lines of code changed in 1 file:

damato 2006-12-19 10:53 Rev.: 2577

* YAM_AB.c: change the LDIF import routines to work case insensitive in
finding its token. This should be more error proof in case the user
uses LDIF files from other systems not taking care of the case that a
token depends on its case.
* YAM_AB.c: adapted latest added sources to comply more to our STYLEGUIDE.
* YAM_AB.c: fixed some compiler warnings due to limited range of datatypes.
* YAM_AB.c, extrasrc/vastubs.c: added the missing vastubs which broke the
compilation for OS3/m68k recently.

115 lines of code changed in 2 files:

tboeckel 2006-12-18 13:46 Rev.: 2575

* YAM_AB.c: extended the LDIF export to handle special characters according
to RFC 2849.

97 lines of code changed in 1 file:

tboeckel 2006-12-18 09:50 Rev.: 2574

* YAM_AB.c: extended the LDIF import to handle base64 and UTF8 encoded
entries, too. Now there is also an alias created if none is set up during
the import.

177 lines of code changed in 1 file:

tboeckel 2006-12-17 23:53 Rev.: 2572

* YAM_AB.c: added address book import and export functions for raw value lists
with either commas or TABs as delimiters. Also added basic LDIF address book
import and export. All these new functions cover the address books as they
are created by Thunderbird. base64 encoded entries in LDIF files are not
correctly handled yet! All in all this is just a beginning to handle alien
address book files. All imported address books will be appended to the
current address book.

1295 lines of code changed in 1 file:

tboeckel 2006-12-17 23:48 Rev.: 2571

* YAM.c, YAM_UT.c: added new ASL requester cache types for alien address book
import and export.

4 lines of code changed in 1 file:

tboeckel 2006-12-17 23:37 Rev.: 2570

* YAM.c, YAM_UT.c: added new ASL requester cache types for alien address book
import and export.

10 lines of code changed in 4 files:

damato 2006-12-17 15:30 Rev.: 2569

* ImageCache.c: fixed another bug in the image cache where we didn't
reload the image files if YAM was put onto another screen. This might
have caused YAM to display images with incorrect colors.

27 lines of code changed in 2 files:

damato 2006-12-17 14:31 Rev.: 2568

* ImageCache.c: fixed a bug in the ObtainImage() cache check which may
have caused that the very same image file was cached multiple times
due to filename check that didn't take respect of absolute file
pathes.

54 lines of code changed in 3 files:

damato 2006-12-16 20:47 Rev.: 2567

* YAM_MI.c: fixed bug #1610171 where it happend that on broken base64
encoded mails YAM did end up in a buffer overrun which might have
ended up in a crash.

18 lines of code changed in 2 files:

damato 2006-12-16 17:25 Rev.: 2566

* MainFolderListtree.c: fixed bug #1615279 where upon a right click in
an empty folder listtree area an illegal memory access caused a crash.

1 lines of code changed in 1 file:

damato 2006-12-16 01:25 Rev.: 2565

* YAM_MA.c, YAM_MAf.c: fixed an issue with the busy gauge cancelation
while index rescanning. Previously the gauge had to be canceled twice
due to an immediate folder refresh after the aborted index rescan. Now
the whole GUI items will be disabled and cleared instead.

47 lines of code changed in 2 files:

damato 2006-12-15 11:26 Rev.: 2564

* Makefile.aros: added a first simple makefile for trying to get YAM
natively compiled for AROS one day. :) However, it doesn't compile at
all yet and more work has to be put into getting YAM ported to AROS.
* misc: minor debugging relevant changes.

32 lines of code changed in 6 files:

tboeckel 2006-12-11 09:00 Rev.: 2561

* YAM_COs.c: if the spam filter has been disabled but the user chose to keep
the spam folder it is now converted to a normal folder, which can be deleted
later.

27 lines of code changed in 1 file:

damato 2006-12-11 02:34 Rev.: 2560

* misc: finalized the first working version which uses TheBar.mcc instead
of the old and obsolete Toolbar.mcc. Now YAM fully uses TheBar.mcc for
every window toolbar. However, please note that the Key Qualifiers are
currently not working with TheBar.mcc as a qualifier check is not yet
implemented in TheBar.mcc. So this is work in progress. In addition,
the new Toolbar classes currently still use the PROGDIR:Icons directory
whereas that will soonish change. So you have been warned!
* locale/YAM.cd: rephrased some text passages and added hotkey shortcuts
to the recently added requester buttons.
* YAM_WR.c: added the missing "Search" menu item and changed the shortcut
for it to match the same for starting a search in the main window. Please
note that for attaching a file the shortcut had to be changed and is
now RAmiga+A instead of RAmiga+F.

577 lines of code changed in 20 files:

damato 2006-12-10 11:30 Rev.: 2558

* YAM_FO.c, YAM_gloabal.c, YAM_folderconfig.h, YAM_global.h: moved the
FolderName array to YAM_FO.c to avoid Library base definition problems
accross platforms.

19 lines of code changed in 4 files:

tboeckel 2006-12-09 16:08 Rev.: 2555

* YAM_COs.c: the free()ing of the spam folder upon deleting it was completely
wrong and caused unpredictable system misbehaviour. The folder structure is
already deleted by the folder treeview's destructor. This should also fix
bug #1611908.

0 lines of code changed in 1 file:

tboeckel 2006-12-09 15:42 Rev.: 2554

* YAM_FO.c: the type of the spam folder was displayed as "sent" instead of
"received". Even if this type cannot be changed it should be shown
correctly. Also made sure that a newly created folder always gets its
standard icon displayed in the folder tree. Before a newly created spam
folder got no icon until the user clicked on the folder for the first time.

11 lines of code changed in 1 file:

damato 2006-12-09 15:33 Rev.: 2553

* YAM_folderconfig.h, misc: the "isSpamFolder()" macro now generally also
checks the "C->SpamFilerEnabled" variable which seems to be more
appropriate. So if the Spam functionality is generally disabled, that
macro will always return FALSE.

7 lines of code changed in 6 files:

damato 2006-12-09 15:19 Rev.: 2552

* YAM_MA.c, YAM_FO.c, YAM_MAf.c, misc: renamed the default "Deleted" folder
to the more common name "Trash" and adapted all involved functions to
deal with a "trash" folder instead. Also adapted the "FolderName"
array which carries all names of our default folders.

110 lines of code changed in 15 files:

damato 2006-12-09 12:31 Rev.: 2550

* YAM_MA.c: slightly reworked the new DeleteSpamHook() function once again
to enable it to delete spam mails not only from the spam folder as this
is like it is done in Thunderbird. In addition, the "Empty trash" command
is now always available and not ghosted on other folder than the trash
folder. Just the context menu of those folders have to be different.

13 lines of code changed in 1 file:

tboeckel 2006-12-09 10:07 Rev.: 2549

* YAM_MA.c: the checks to enable/disable some menu items were a little bit
too picky. For example checking a folder for being the deleted folder is
enough as this cannot be a group folder then. And menu items performing an
action on the whole folder don't need to check for a certain number of mails
to be selected.

2 lines of code changed in 1 file:

damato 2006-12-09 02:54 Rev.: 2548

* YAM_MA.c, MainFolderListtree.c, locale/YAM.cd: the newly added menu item
for deleting all mails in the spam folder will now only be active if the
SPAM folder is the current folder. In addition, the context menu of the
spam folder now also caries a menu item for deleting all SPAM in it.

75 lines of code changed in 3 files:

damato 2006-12-09 01:52 Rev.: 2547

* InfoBar.c, YAM_MA.c, YAM_UT.c, YAM_FI.c, YAM_MAf.c: a shown busy gauge
in the infobar can now contain a small "X" button which will allow the
BusySet() function to notify the calling function that the user wants to
abort a certain operation. This allows now to not only abort the filtering
action, it also allows to abort a manual index rescanning operation as well
as other move/delete mail operations which are manually executed by the
user. In fact, that new functionality should hopefully address a long
existing nuisance in YAM.

189 lines of code changed in 6 files:

tboeckel 2006-12-09 00:01 Rev.: 2546

* YAM_MA.c, YAM_main.h, locale/YAM.cd, locale/deutsch.ct: added menu item to
delete all spam mails from the spam folder. This function will respect non
spam mail that may still reside in the spam folder will keep them.

82 lines of code changed in 2 files:

tboeckel 2006-12-08 19:49 Rev.: 2545

* YAM_UT.c: upon deleting a users private directory the .folders file is now
deleted, too.

2 lines of code changed in 1 file:

tboeckel 2006-12-08 16:33 Rev.: 2544

* YAM.c, YAM_COs.c: when the user was asked if the spam folder should be
created in an already existing directory the case that the requester was
cancelled was not really handled.

33 lines of code changed in 2 files:

damato 2006-12-08 09:58 Rev.: 2542

* YAM_UT.c, Splashwindow.c: moved the Update minimazation code to the
corresponding Splashwindow class instead of doing the analysis with help
of a static variable directly in the Busy() function.

115 lines of code changed in 3 files:

damato 2006-12-08 02:03 Rev.: 2541

* YAM_FI.c, YAM_RE.c: The new "Check for spam" operation didn't show any Busy
gauge while processing mails. Now it will correctly show and update a busy
bar like the normal filter operation. In addition it will show a more specific
message than just "Applying filters...".

45 lines of code changed in 2 files:

tboeckel 2006-12-07 22:17 Rev.: 2537

* YAM_COs: added the possibility to use an already existing spam folder as
standard spam folder when the spam filter has just been enabled, but without
deleting the files in this existing folder.

21 lines of code changed in 1 file:

tboeckel 2006-12-07 22:13 Rev.: 2535

* ReadWindow.c: added some extra checks if the spam filter is really
enabled and made sure the window is closed after the last mail in a
folder has been deleted.

24 lines of code changed in 1 file:

tboeckel 2006-12-07 22:11 Rev.: 2534

* YAM_FI.c, YAM_main.h: adapted the setStatusToAutoSpam() macro to do the
right thing and not to clear too many flags.

1 lines of code changed in 1 file:

tboeckel 2006-12-07 22:10 Rev.: 2533

* MainMailList.c: added some extra checks if the spam filter is really
enabled

4 lines of code changed in 1 file:

tboeckel 2006-12-07 22:00 Rev.: 2532

* YAM_MA.c: added new menu item "Check mails for spam content" to check a
complete folder for spam mails. Detected spam will be moved to the spam
folder.
* YAM_MA.c, YAM_CO.c: integrated dynamical adding/removing of the spam menu
entries into MA_SetupDynamicMenus().

57 lines of code changed in 3 files:

tboeckel 2006-12-06 23:14 Rev.: 2531

* YAM_MI.c: removed unnecessary check during CRLF conversion.

1 lines of code changed in 1 file:

tboeckel 2006-12-06 21:28 Rev.: 2530

* YAM.c: removed a redundand statement for debugging purposes

1 lines of code changed in 1 file:

tboeckel 2006-12-06 21:11 Rev.: 2529

* YAM_COs.c: after deleting the spam folder when the spam filter was deacti-
vated the folder structure is free()ed now and the statistics are updated,
too (same misbehaviour as bug #1609972)

4 lines of code changed in 1 file:

tboeckel 2006-12-06 21:09 Rev.: 2528

* YAM_FO.c: added a missing DisplayStatistics() call after deleting a folder.
This fixes bug #1609972.

3 lines of code changed in 1 file:

tboeckel 2006-12-06 18:46 Rev.: 2526

* YAM_UT.c: before a sound object from a previous call of PlaySound() is
disposed, its playback is stopped now. Maybe this fixes the freezes with
MOS.

15 lines of code changed in 1 file:

tboeckel 2006-12-05 23:00 Rev.: 2525

* YAM_FO.c: added also some checks if the spam filter is active when the
folder type and the folder images for a possibly spam folder are set up.

2 lines of code changed in 1 file:

tboeckel 2006-12-05 07:30 Rev.: 2522

* UpdateCheck.c: fixed bug #1604415. If the update check results in either no
available updates or an available update the last update time in the config
window is updated. This does not happen in case of an error.

5 lines of code changed in 1 file:

tboeckel 2006-12-04 23:13 Rev.: 2521

* locale/deutsch.ct: fixed some typos
* YAM_COs.c: added the same checks when creating the spam folder after the
spam filter has been activated in the configuration window as upon startup.
If something goes wrong the user is prompted with an error window and the
spam filter is disabled again.

37 lines of code changed in 1 file:

tboeckel 2006-12-04 22:51 Rev.: 2520

* YAM_UT.c: added some more checks if the spam filter is active when the
folder type and the folder images for a possibly spam folder are set up. An
inactive spam filter will result in a standard custom folder in all cases
now.

1 lines of code changed in 1 file:

tboeckel 2006-12-04 22:47 Rev.: 2519

* YAM.c, locale/YAM.cd: if a directory named "spam" already exists upon
startup but is not the standard spam folder the user now gets asked what
to do. The user has the choice to use this directory as spam folder and
delete all existing files or to disable the spam filter. This should
prevent unwanted loss of mails in case someone already has created such
a directory without having the spam filter activated.

51 lines of code changed in 1 file:

tboeckel 2006-12-04 19:07 Rev.: 2517

* YAM_FI.c: the user defined filters were not working anymore if the spam
filter was not active, because YAM always wanted to obtain the spam folder,
which does not exist without the spam filter being active.

2 lines of code changed in 1 file:

tboeckel 2006-12-04 07:52 Rev.: 2515

* YAM_FI.c: the last change was just nearly the complete thing. All new mails
were correctly checked for spam content, but the NEW and UNREAD flags were
always cleared. Hence one didn't really see that there was new spam (or even
false spam!).

2 lines of code changed in 1 file:

damato 2006-12-04 02:31 Rev.: 2514

* locale/YAM.cd, deutsch.ct: small modifications to recently changes passages.

6 lines of code changed in 1 file:

tboeckel 2006-12-03 21:11 Rev.: 2513

* YAM_FI.c: reworked the spam filtering a bit again. Now it should always work
as expected.

32 lines of code changed in 1 file:

damato 2006-12-03 16:07 Rev.: 2511

* YAM_TR.c, YAM_COg.c, YAM_COs.c, YAM_CO.c: added the possibility to explicitly
select the SMTP-AUTH method in the configuration of YAM. Some SMTP servers
out there seem to report authentication methods on connect which they however
do not support so that an automatic selection of the AUTH methods isn't always
successfull. Now a user can override the automatic selection by explicitly
selecting one of the supported SMTP-AUTH methods.

203 lines of code changed in 6 files:

tboeckel 2006-12-03 13:03 Rev.: 2509

* YAM_COs.c: added the missing code to completely delete the spam folder if
the spam filter has been deactivated.

55 lines of code changed in 1 file:

tboeckel 2006-12-03 13:02 Rev.: 2508

* YAM_UT.c: CheckboxRequest() always returned a negative value, even if the
user selected all checkboxes and hit "Use" in the end.

3 lines of code changed in 1 file:

tboeckel 2006-12-03 12:59 Rev.: 2507

* YAM_FO.c, YAM_folderconfig.h: added new function FO_GetFolderTreeNode() to
obtain the treenode which belongs to a folder structure. This will needed be
needed to delete arbitrary folders without selecting them (e.g. the spam
folder)

33 lines of code changed in 2 files:

tboeckel 2006-12-03 12:58 Rev.: 2506

* YAM_FO.c: when the creation of a new folder fails YAM tried to remove the
newly created treenode from the folder tree, but passed the wrong pointer
which made NListtree.mcc go crazy. Now it correctly passes a treenode
instead of a folder structure.

16 lines of code changed in 1 file:

tboeckel 2006-12-03 11:23 Rev.: 2505

* YAM_UT.c: when a folder is deleted and has its own folder icon this icon
file is not deleted aswell. Before the directory was still kept, because
it was not empty because of the still existing .fimage file.

1 lines of code changed in 1 file:

tboeckel 2006-12-01 17:52 Rev.: 2504

* YAM_FI.c: the recent changes complete broke the spam filtering. Now new
mails are checked for spam content (if enabled) and are moved to the spam
folder.

6 lines of code changed in 1 file:

damato 2006-12-01 11:08 Rev.: 2502

* YAM_MA.c: reworked the menu item enable/disable routine a bit to make it
more clear under which conditions a menu item should be disabled/enabled.
Also added the new MI_DELDEL which was missing and reworked the Spam
menu item and toolbar item disable/enable routines to just disable it
if there is no multiselection active.

88 lines of code changed in 2 files:

tboeckel 2006-12-01 07:49 Rev.: 2501

* YAM_MA.c: the attachment menu is now also disabled for empty folders

1 lines of code changed in 1 file:

November 2006 »

Generated by StatSVN 0.7.0